Address edge case where temp info is reset when brightness goes below 0.0 in delta mode #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mode This quirk is explained in the README. Basically if the brightness that's passed to get_sct_for_screen() is less than or equal to zero, the temperature is 'set' to 0. This means that if we were using delta mode to decrease the brightness, the temperature information will be lost whenever the brightness becomes less than or equal to 0. Before this commit, this would manifest itself by forcing the temperature to 700K. For example, doing `xsct 6500 -1; xsct -d 0 1` would result in a red screen, even though we didn't intend to change the color temperature. Ideally, the temperature information should stay the same if we are only shifting the brightness and we reach 0.0, but I couldn't think of a straightforward way to implement this. Also add a fix to make sure temp and brightness are included when using the delta flag
faf0
reviewed
Jun 25, 2024
faf0
reviewed
Jun 25, 2024
|
Thanks for your contribution, @j-silv ! I think after the suggested changes, this is good to merge. |
Co-authored-by: Fabian Foerg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit the temperature would be reset to
TEMPERATURE_ZEROif the brightness was reduced to 0.0 in delta mode. Now it resets toTEMPERATURE_NORM. I noticed this because I have a keyboard shortcut which can quickly reduce and increase brightness using the delta mode.If you want to test it, you can do:
xsct 6500 -1; xsct -d 0 1. This results in a red screen, even though it wasn't intended to change the temperature from 6500.Now the temperature is reset to 6500, which isn't the perfect solution, but at least it's somewhat aligned to passing 0 as a parameter to
xsctin absolute mode.Also add small fix to make sure both temp and brightness are provided when in delta mode.