Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional attrib #201

Merged
merged 3 commits into from
May 13, 2022
Merged

Optional attrib #201

merged 3 commits into from
May 13, 2022

Conversation

imrehg
Copy link
Member

@imrehg imrehg commented May 13, 2022

It was changed in #180 which broke direct Project creation, that is 0.27.2 if this library.

Noticed because since that version the faculty-cli tests are not passing, instead currently throwing an error:

ImportError while loading conftest '/Users/gergely/faculty/faculty-cli/test/conftest.py'.
test/conftest.py:17: in <module>
    from test.fixtures import PROFILE, USER_ID
test/fixtures.py:30: in <module>
    PROJECT = Project(id=uuid.uuid4(), name="test-project", owner_id=USER_ID)
E   TypeError: __init__() missing 1 required positional argument: 'archived_at'
ERROR: InvocationError for command /Users/gergely/faculty/faculty-cli/.tox/py38/bin/pytest --cov=faculty_cli (exited with code 4)

Testing it locally with:

python -c "import uuid; from faculty.clients.project import Project; Project(id=uuid.uuid4(), name='test-project', owner_id=uuid.uuid4())"

NB: need #200 for linting to correctly pass here.

Also this should be a short term / temporary change, and extra work stemming from #197 (followed up in #199) should fix this differently over the long run. The test change within this PR should protect against future issue like this.

@acroz
Copy link
Member

acroz commented May 13, 2022

LGTM, modulo getting the test to pass.

@imrehg
Copy link
Member Author

imrehg commented May 13, 2022

@acroz done!

@acroz acroz merged commit 147c45d into facultyai:master May 13, 2022
@acroz
Copy link
Member

acroz commented May 13, 2022

@imrehg I've released this to PyPI as 0.30.2

@imrehg imrehg deleted the optional-attrib branch May 14, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants