This repository has been archived by the owner on Nov 21, 2023. It is now read-only.
use opencv instead of numpy to subtract pixel means #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using numpy to subtract pixel means is slow when image is not small.
As we already using opencv to do image resizing, I think it' better to also use opencv to do subtraction.
By using opencv, it can reduce total inference time by about 10ms on my 8700K machine for an image with size 1352x900.
The following test code shows the correctness and performance gain.
Some test results:
On 8700K machine:
('numpy timecost', 0.025714427947998046)
('opencv timecost', 0.0030607531070709227)
On 6850K machine:
('numpy timecost', 0.032919152021408084)
('opencv timecost', 0.004819504976272583)
On some Azure cheap instance:
numpy timecost 0.2105223798751831
opencv timecost 0.03022796869277954