feat: Support rewrite of complex type functions when they are accesse… #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
Contributor
Contributor
Contributor
oerling
added a commit
to oerling/verax
that referenced
this pull request
Aug 30, 2025
facebookincubator#313) Summary: …d as a whole We have a case of f(make_row_from_map(c, ids, names)). f is unknown. When accessing the map as a row and projecting the columns of the row as top level columns, we expect make_row_from_map to become a row constructor. This is different from the case of getters or oyther known functions over make_row_from_map, where the getter is replaced by the top level column and there is no make_row_from_map. We add a hook to FunctionMetadata for this. Differential Revision: D81358390 Pulled By: oerling
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81358390 |
Contributor
MBkkt
reviewed
Sep 1, 2025
…d as a whole We have a case of f(make_row_from_map(c, ids, names)). f is unknown. When accessing the map as a row and projecting the columns of the row as top level columns, we expect make_row_from_map to become a row constructor. This is different from the case of getters or oyther known functions over make_row_from_map, where the getter is replaced by the top level column and there is no make_row_from_map. We add a hook to FunctionMetadata for this.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d as a whole
We have a case of f(make_row_from_map(c, ids, names)). f is unknown. When accessing the map as a row and projecting the columns of the row as top level columns, we expect make_row_from_map to become a row constructor.
This is different from the case of getters or oyther known functions over make_row_from_map, where the getter is replaced by the top level column and there is no make_row_from_map.
We add a hook to FunctionMetadata for this.