Skip to content

Commit

Permalink
Fetch repo callsign
Browse files Browse the repository at this point in the history
Summary: Phabricator repos want to have an ID they can use to refer to repos. We can get this from the `phrevset.callsign`.

Differential Revision: D64490625

fbshipit-source-id: 33ddb8b73efbb4e4a91dd27677af758057e40ec8
  • Loading branch information
evangrayk authored and facebook-github-bot committed Oct 16, 2024
1 parent bda12d5 commit 112b915
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion addons/isl-server/src/Repository.ts
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,7 @@ export class Repository {
'paths.default',
'github.pull_request_domain',
'github.preferred_submit_command',
'phrevset.callsign',
]),
]);
const pathsDefault = configs.get('paths.default') ?? '';
Expand Down Expand Up @@ -507,7 +508,7 @@ export class Repository {
if (Internal.isMononokePath?.(pathsDefault)) {
// TODO: where should we be getting this from? arcconfig instead? do we need this?
const repo = pathsDefault.slice(pathsDefault.lastIndexOf('/') + 1);
codeReviewSystem = {type: 'phabricator', repo};
codeReviewSystem = {type: 'phabricator', repo, callsign: configs.get('phrevset.callsign')};
} else if (pathsDefault === '') {
codeReviewSystem = {type: 'none'};
} else {
Expand Down
1 change: 1 addition & 0 deletions addons/isl/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ export type CodeReviewSystem =
| {
type: 'phabricator';
repo: string;
callsign?: string;
}
| {
type: 'none';
Expand Down

0 comments on commit 112b915

Please sign in to comment.