Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert circleci workflow devtools_regression_tests to github actions #27800

Merged

Conversation

robandpdx
Copy link
Contributor

@robandpdx robandpdx commented Dec 6, 2023

Summary

This pull request converts the CircleCI workflows to GitHub actions workflows. Github Actions Importer was used to convert the workflows initially, then I edited them manually to correct errors in translation.

Issues

  1. facebook/react/devtools_regression_tests
    The scripts that this workflow calls need to be modified.

How did you test this change?

I tested these changes in a forked repo. You can view the logs of this workflow in my fork.

https://fburl.com/workplace/f6mz6tmw

@react-sizebot
Copy link

react-sizebot commented Dec 6, 2023

Comparing: 0066e0b...e66bfb8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 177.10 kB 177.10 kB = 55.19 kB 55.19 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.64 kB 177.64 kB = 55.52 kB 55.52 kB
facebook-www/ReactDOM-prod.classic.js = 594.36 kB 594.36 kB = 104.96 kB 104.96 kB
facebook-www/ReactDOM-prod.modern.js = 577.62 kB 577.62 kB = 102.01 kB 102.01 kB
test_utils/ReactAllWarnings.js Deleted 66.60 kB 0.00 kB Deleted 16.28 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 66.60 kB 0.00 kB Deleted 16.28 kB 0.00 kB

Generated by 🚫 dangerJS against e66bfb8

@kassens kassens force-pushed the cci2actions-devtools-regression-tests branch from 20f0679 to e66bfb8 Compare March 6, 2024 18:05
@hoxyq hoxyq merged commit 496e873 into facebook:main Apr 18, 2024
38 checks passed
rickhanlonii added a commit that referenced this pull request Apr 18, 2024
@rickhanlonii
Copy link
Member

Heads up I reverted this because it broke main. @robandpdx can you re-submit the PR?

@robandpdx
Copy link
Contributor Author

@rickhanlonii #28875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants