react-hooks/rules-of-hooks: Add support for do/while loops
#28714
Conversation
|
Hi @tyxla! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
tyxla
changed the title
react-hooks/rules-of-hooks: Add support for do/while loops
|
Comparing: 6e65010...33a8918 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
@eps1lon I noticed you've been working on the ESLint rules, will you have a chance to take a look? Thanks 🙌 |
Summary
Currently,
react-hooks/rules-of-hooksdoes not supportdo/whileloops - I've also reported this in #28713.This PR takes a stab at adding support for
do/whileby following the same logic we already have for detectingwhileloops.After this PR, any hooks called inside a
do/whileloop will be considered invalid.We're also adding some unit tests to confirm that the behavior is working as expected.
Fixes #28713.
How did you test this change?
I've added unit tests that cover the case and verified that they pass by running:
I've also verified that the rest of the tests continue to pass by running:
and