New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: react-hooks/rules-of-hooks
does not support do/while
loops
#28713
Comments
I've worked on fixing this in #28714 |
Maybe instead of using do while loop you can do conditional rendering, create a state of condition and render the hook based on the condition. In this method the hook won't be executed more than once! |
@pranshu05 this issue isn't about how to write conditional or loop hooks in React. This is about the ESLint rule that catches whether someone is using a hook potentially in a loop. There's no guaranteed way through static code analysis to catch if a loop will iterate more than once or not. Also, the rules of hooks ESLint rule already warns if someone is using a hook in a |
React version: 18.2.0
Steps To Reproduce
Use a hook inside a
do/while
loop.You'll see that it's not considered a violation of the rule.
Code example:
The current behavior
The
react-hooks/rules-of-hooks
does not consider hook usage inside ado/while
loop a violation.The expected behavior
I expected that I'd see the following ESLint error:
The text was updated successfully, but these errors were encountered: