[RN][Codegen] add missing struct member initialization in Props.h #44294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: ab00a45 |
alanleedev
force-pushed
the
export-D56659457
branch
from
82454a0
to
fcd144b
Compare
alanleedev
changed the title
Summary: **Problem:** It was discovered while testing 3 party library, generated member variables in a C++ `struct` in `Props.h` is not initialized. Also `WithDefault` would not work as well. (For the problematic case it was a `boolean` but would also apply to other primitive types.) If there is no default initialization and the component prop is optional and the user of the native component does not set the prop then the variable is never initialized and this is problematic for primitive types in C++ where no initialization results in an undefined behavior. **Proposed solution:** (Following C++Core Guideline of [always initialize](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-always).) Reusing `generatePropsString()` used by `ClassTemplate` to generate props for `StructTemplate` as well. updated relevant test snapshots. This change is only concerning the `Props.h` file. **Changelog:** [General][Fixed] - fixed `Props.h` created from codegen missing default initializers in C++ `struct` Differential Revision: D56659457
alanleedev
force-pushed
the
export-D56659457
branch
from
fcd144b
to
8b9a70e
Compare
|
This pull request has been merged in 639d890. |
|
This pull request was successfully merged by @alanleedev in 639d890. When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
May 1, 2024
Summary: Pull Request resolved: #44294 **Problem:** It was discovered while testing 3 party library, generated member variables in a C++ `struct` in `Props.h` is not initialized. Also `WithDefault` would not work as well. (For the problematic case it was a `boolean` but would also apply to other primitive types.) If there is no default initialization and the component prop is optional and the user of the native component does not set the prop then the variable is never initialized and this is problematic for primitive types in C++ where no initialization results in an undefined behavior. **Proposed solution:** (Following C++Core Guideline of [always initialize](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-always).) Reusing `generatePropsString()` used by `ClassTemplate` to generate props for `StructTemplate` as well. updated relevant test snapshots. This change is only concerning the `Props.h` file. **Changelog:** [General][Fixed] - fixed `Props.h` created from codegen missing default initializers in C++ `struct` Reviewed By: cipolleschi Differential Revision: D56659457 fbshipit-source-id: 0d21ad20c0491a7e8bb718cd3156da65def72f23
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
May 6, 2024
Summary: Pull Request resolved: facebook#44294 **Problem:** It was discovered while testing 3 party library, generated member variables in a C++ `struct` in `Props.h` is not initialized. Also `WithDefault` would not work as well. (For the problematic case it was a `boolean` but would also apply to other primitive types.) If there is no default initialization and the component prop is optional and the user of the native component does not set the prop then the variable is never initialized and this is problematic for primitive types in C++ where no initialization results in an undefined behavior. **Proposed solution:** (Following C++Core Guideline of [always initialize](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-always).) Reusing `generatePropsString()` used by `ClassTemplate` to generate props for `StructTemplate` as well. updated relevant test snapshots. This change is only concerning the `Props.h` file. **Changelog:** [General][Fixed] - fixed `Props.h` created from codegen missing default initializers in C++ `struct` Reviewed By: cipolleschi Differential Revision: D56659457 fbshipit-source-id: 0d21ad20c0491a7e8bb718cd3156da65def72f23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Problem:
It was discovered while testing 3 party library, generated member variables in a C++
structinProps.his not initialized.For the problematic case it was a
booleanbut would also apply to other primitive types.If there is no default initialization and the component prop is optional and the user of the native component does not set the prop then the variable is never initialized and this is problematic for primitive types in C++ where no initialization results in an undefined behavior.
Proposed solution:
(Following C++Core Guideline of always initialize.)
Reusing
generatePropsString()used byClassTemplateto generate props forStructTemplateas well.updated relevant test snapshots.
This change is only concerning the
Props.hfile.Differential Revision: D56659457