fix Flow failure breaking yarn run build #44290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
blakef
force-pushed
the
export-D56638506
branch
from
c0b6cd1
to
203520d
Compare
Summary: `flow-api-translator` can't handle `module.exports`. Shift this to ESM style exports like the other built packages. Changelog: [Internal] - Fixing an internal build script broken by D56243647 Reviewed By: cipolleschi Differential Revision: D56638506
blakef
force-pushed
the
export-D56638506
branch
from
203520d
to
9b5909b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
flow-api-translatorcan't handlemodule.exports. Simplest fix is to not identifythe bridging file (that we use to register with babel to transpile when run directly)
as a flow file.
Changelog: [Internal] - Fixing an internal build script broken by D56243647
Differential Revision: D56638506