fix a crash in <Modal /> component #44277
Open
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: changelog: [Android][Fixed] - fix a crash in Modal component Instance variable `propertyRequiresNewDialog` in `ReactModalHostView` controls if new dialog will be created on next `showOrUpdate` or not. It must be kept in sync with `dialog` ivar. if `dismiss` is ever called from anywhere but `showOrUpdate`, the class gets into a state where the next `showOrUpdate` call will throw an error because dialog is set to null but `propertyRequiresNewDialog` stays false. `dismiss` is called from three places: `showOrUpdate` (this is ok), `onDropInstance()` and `onDetachedFromWindow`. The fix in this diff is to make sure propertyRequiresNewDialog is set to true when dialog is dismissed. Differential Revision: D56627522
facebook-github-bot
added
CLA Signed
Base commit: be06fd4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [Android][Fixed] - fix a crash in Modal component
Instance variable
propertyRequiresNewDialoginReactModalHostViewcontrols if new dialog will be created on nextshowOrUpdateor not. It must be kept in sync withdialogivar.if
dismissis ever called from anywhere butshowOrUpdate, the class gets into a state where the nextshowOrUpdatecall will throw an error because dialog is set to null butpropertyRequiresNewDialogstays false.dismissis called from three places:showOrUpdate(this is ok),onDropInstance()andonDetachedFromWindow.The fix in this diff is to make sure propertyRequiresNewDialog is set to true when dialog is dismissed.
Differential Revision: D56627522