RN: Further Optimize createAnimatedComponent
#44275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
yungsters
force-pushed
the
export-D56621191
branch
2 times, most recently
from
93ad288
to
de2e387
Compare
Summary: Changes two important aspects of `StyleSheet.compose`: - Extract it from `StyleSheet` so that it can be imported from other internal modules without incurring circular dependencies. (Surprisingly, `StyleSheet` has a lot of dependencies.) - Avoid a redundant `style1 != null` check. Changelog: [General][Changed] - Optimized performance of `StyleSheet.compose` Reviewed By: sammy-SC Differential Revision: D56621407
Summary: In addition to memoizing `mergedStyle` in `createAnimatedComponent`, this avoids unnecessary object allocations by: * Not allocating `passthroughProps`, created via a rest spread operator. It is unnecessary because we always override `style` in the JSX. * Not allocating a new object if either `style` or `passthroughStyle` are null or undefined. Also, create an array of the two style objects instead of spreading them, which is needless. Changelog: [General][Changed] - Improved performance of `Animated` components Reviewed By: sammy-SC Differential Revision: D56621191
yungsters
force-pushed
the
export-D56621191
branch
from
de2e387
to
33ae258
Compare
Base commit: be06fd4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In addition to memoizing
mergedStyleincreateAnimatedComponent, this avoids unnecessary object allocations by:passthroughProps, created via a rest spread operator. It is unnecessary because we always overridestylein the JSX.styleorpassthroughStyleare null or undefined. Also, create an array of the two style objects instead of spreading them, which is needless.Changelog:
[General][Changed] - Improved performance of
AnimatedcomponentsReviewed By: sammy-SC
Differential Revision: D56621191