Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Remove _logWarnIfCreateRootViewWithBridgeIsOverridden #44271

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[iOS] Remove _logWarnIfCreateRootViewWithBridgeIsOverridden #44271

wants to merge 2 commits into from

Conversation

zhongwuzw
Copy link
Contributor

Summary:

Fixes customizeRootView migration comment. cc @cipolleschi

Changelog:

[IOS] [FIXED] - Fixes customizeRootView migration comment

Test Plan:

image

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Apr 26, 2024
@analysis-bot
Copy link

analysis-bot commented Apr 26, 2024 •
edited

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,460,008 -95
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,833,614 -8
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: be06fd4
Branch: main

@zhongwuzw zhongwuzw changed the title [iOS] Fixes customizeRootView migration comment [iOS] Remove _logWarnIfCreateRootViewWithBridgeIsOverridden Apr 26, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi requested changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhongwuzw @analysis-bot @facebook-github-bot @cipolleschi