Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing remove method to addEventListener Jest mocks #44270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

levibuzolic
Copy link
Contributor

@levibuzolic levibuzolic commented Apr 26, 2024

Summary:

While writing some Jest tests, I noticed some instances of the following error:

Cannot read properties of undefined (reading 'remove')

Looks like there were two cases where the {remove: () => {}} return result was missing in the provided Jest mocks:

  • AccessibilityInfo.addEventListener
  • Linking.addEventListener

Changelog:

[GENERAL] [FIXED] - Added missing remove methods for Linking.addEventListener and AccessibilityInfo.addEventListener Jest mocks

Test Plan

N/A

Adds missing `remove` return object for `Linking.addEventListener` and `AccessibilityInfo.addEventListener` in the Jest mocks
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 26, 2024
@levibuzolic levibuzolic changed the title Add missing remove method to addEventListener mocks Add missing remove method to addEventListener Jest mocks Apr 26, 2024
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants