Skip to content

Improve termination screen #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025
Merged

Improve termination screen #160

merged 3 commits into from
May 13, 2025

Conversation

vzaidman
Copy link

@vzaidman vzaidman commented May 9, 2025

Summary

Improve termination dialog with the following:

  • Commit 1- add a session ID, if it exists, to the feedback message. Also improve the color of the error reason to be more prominent.
  • Commit 2- add the option to display why devtools got disconnected.
  • Commit 3- add a custom message to be displayed to users in certain cases when a disconnection happens. Also, allow selecting the text in that dialog for easier debugging.

Test plan

See D74485072

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.
    • Due to this refactoring a RN specific dialog

vzaidman added a commit to vzaidman/react-native that referenced this pull request May 9, 2025
Summary:
Corresponding OS PR:
facebook/react-native-devtools-frontend#160

Improve termination dialog with the following:
* Commit 1- add a session ID, if it exists, to the feedback message.
* Commit 2- add the option to display why devtools got disconnected.
* Commit 3- add a custom message to be displayed to users in certain cases when a disconnection happens.

Differential Revision: D74484316
@vzaidman vzaidman force-pushed the improve-termination-screen branch from fa27309 to 0ec210d Compare May 9, 2025 16:38
Copy link
Member

@huntie huntie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address nits

@vzaidman vzaidman force-pushed the improve-termination-screen branch 2 times, most recently from 07dff31 to da27b6a Compare May 13, 2025 09:13
@vzaidman vzaidman force-pushed the improve-termination-screen branch from da27b6a to 6aa6cc2 Compare May 13, 2025 09:37
@@ -25,6 +26,8 @@ const UIStrings = {
docsLabel: 'Debugging docs',
/** @description "What's new" link */
whatsNewLabel: "What's new",
/** @description Description for sharing the session ID of the current session with the user */
sessionIdMessage: "[FB-only] The session ID for this React Native DevTools lauch is: ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, plus suggested shortening:

Suggested change
sessionIdMessage: "[FB-only] The session ID for this React Native DevTools lauch is: ",
sessionIdMessage: "[FB-only] The ID for this React Native DevTools session is: ",

@vzaidman vzaidman merged commit eb7948b into main May 13, 2025
2 of 3 checks passed
@vzaidman vzaidman deleted the improve-termination-screen branch May 13, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants