Improve termination screen #160
Merged
+112
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
May 9, 2025
Summary: Corresponding OS PR: facebook/react-native-devtools-frontend#160 Improve termination dialog with the following: * Commit 1- add a session ID, if it exists, to the feedback message. * Commit 2- add the option to display why devtools got disconnected. * Commit 3- add a custom message to be displayed to users in certain cases when a disconnection happens. Differential Revision: D74484316
vzaidman
force-pushed
the
improve-termination-screen
branch
from
fa27309 to
0ec210d
Compare
vzaidman
force-pushed
the
improve-termination-screen
branch
2 times, most recently
from
07dff31 to
da27b6a
Compare
vzaidman
force-pushed
the
improve-termination-screen
branch
from
da27b6a to
6aa6cc2
Compare
huntie
approved these changes
May 13, 2025
| @@ -25,6 +26,8 @@ const UIStrings = { | |||
| docsLabel: 'Debugging docs', | |||
| /** @description "What's new" link */ | |||
| whatsNewLabel: "What's new", | |||
| /** @description Description for sharing the session ID of the current session with the user */ | |||
| sessionIdMessage: "[FB-only] The session ID for this React Native DevTools lauch is: ", | |||
There was a problem hiding this comment.
Typo, plus suggested shortening:
Suggested change
| sessionIdMessage: "[FB-only] The session ID for this React Native DevTools lauch is: ", | |
| sessionIdMessage: "[FB-only] The ID for this React Native DevTools session is: ", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve termination dialog with the following:
Test plan
See D74485072
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.