Skip to content

feat: define global for enabling Performance #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

hoxyq
Copy link

@hoxyq hoxyq commented May 6, 2025

Summary

Defined a field on globalThis that can be used for disabling the experiment around Performance panel, and which will enable it by default.

The type any is used because technically, this value is defined at runtime and we can't guarantee its type.

Test plan

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@hoxyq hoxyq merged commit cbb8c83 into main May 7, 2025
2 of 3 checks passed
hoxyq added a commit that referenced this pull request May 7, 2025
@hoxyq hoxyq deleted the performance/enable-by-default-if-requested branch May 7, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants