Make pyre able to read configuration from pyproject.toml
#799
+136
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
WangGithubUser
force-pushed
the
read_config_from_pyproject
branch
2 times, most recently
from
e6aaa24
to
58f2492
Compare
WangGithubUser
force-pushed
the
read_config_from_pyproject
branch
from
e93dc27
to
b74e8dc
Compare
|
Is this still a |
|
@WangGithubUser @cclauss Is this still active? Would love to see this feature. |
cclauss
reviewed
Apr 24, 2024
| @@ -48,6 +48,9 @@ | |||
| { | |||
| "is_toplevel_module": true, | |||
| "site-package": "typing_inspect" | |||
| }, | |||
| { | |||
| "site-package": "tomli" | |||
There was a problem hiding this comment.
tomli should be used only on Python < 3.11 because in Python >= 3.11 tomllib is in the Standard Library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This PR resolves #695.
I'm not sure we should look for
pyproject.tomlsilently when.pyre_configurationis not valid, or only look for it when a flag provided.But, I prefer the first resoulution because the second need to provide a flag in all runs.However, I want to hear you opinion.Test Plan
Look for if the unittest passed.
As the unittest is not avalible this time(see footnote), I ran test in my local machine with python3.10:
Footnote:
Testfails due tomatchstatement is incompatible with Python3.8 and 3.9, and is not related to this PR.To make this easier to review and avoid confliting, I will rebase this PR on the top of main if thematchstatement refactored withif-elif-elsestatement but not do it in this PR..pyre_configurationat the root of this project after the nightly version of Pyre with this diff deployed.I intergrated configurations intopyproject.toml.