[lexical-table] Bug Fix: table cell background copy paste not working #7232
Conversation
jvithlani
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @jvithlani! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
You'll need to sign the CLA before we can run the tests and possibly merge this PR |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
It doesn't look like this change passes the existing e2e test suite (possibly because the tests should change to accommodate this new behavior), and there are no new tests that verify that it works now. Further work will have to be done here before it can be merged. |
|
@jvithlani are you planning on finishing this one? |
|
Hey @ivailop7, yes ill wrap this up, was a little caught up. Will finish it this week |
jvithlani
force-pushed
the
jv_table_cell_bg
branch
from
de0d178 to
91074d0
Compare
Description
While copy pasting a table cell with backgruond color, the backgruond color doesnt carry forward with the table details
Test plan
Before
Screen.Recording.2025-02-22.at.2.47.52.PM.mov
After
Screen.Recording.2025-02-22.at.2.48.56.PM.mov
Insert relevant screenshots/recordings/automated-tests