Skip to content

DARWIN_NETOS: sync sensor_service #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aalamsi22 wants to merge 3 commits into from
Closed

DARWIN_NETOS: sync sensor_service #379

aalamsi22 wants to merge 3 commits into from

Conversation

@aalamsi22
Copy link
Contributor

@aalamsi22 aalamsi22 commented Apr 2, 2025 •
edited
Loading

Description

Sensor_service changes

  • Sync Darwin sensor_service config to include all sensors.
  • Match pmUnitNames generated used by PM

Testing

sensor_service_hw_test

[       OK ] SensorServiceHwTest.CheckAllSensors (182 ms)
[----------] 6 tests from SensorServiceHwTest (8989 ms total)

[----------] Global test environment tear-down
[==========] 6 tests from 1 test suite ran. (8989 ms total)
[  PASSED  ] 6 tests.

@aalamsi22 aalamsi22 mentioned this pull request Apr 2, 2025
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 2, 2025

@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Scott8440
Copy link
Contributor

Scott8440 commented Aug 14, 2025

@aalamsi22 can you please rebase this PR. It seems some other changes have gone in before we were able to get this one in. Apologies for the delay.

@aalamsi22
Copy link
Contributor Author

aalamsi22 commented Aug 14, 2025

@aalamsi22 can you please rebase this PR. It seems some other changes have gone in before we were able to get this one in. Apologies for the delay.

No problem. I will go through all my open PRs and sync them

@aalamsi22 aalamsi22 force-pushed the sync_darwin_sensor_config branch from 8d6fffe to 08b3bac Compare August 22, 2025 18:32
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 22, 2025

@aalamsi22 has updated the pull request. You must reimport the pull request before landing.

@aalamsi22 aalamsi22 force-pushed the sync_darwin_sensor_config branch from 08b3bac to 9b92a30 Compare November 6, 2025 18:50
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 6, 2025

@aalamsi22 has updated the pull request. You must reimport the pull request before landing.

@meta-codesync
Copy link

meta-codesync bot commented Nov 21, 2025

@joancaneus has imported this pull request. If you are a Meta employee, you can view this in D72351887.

@joancaneus
Copy link
Contributor

joancaneus commented Nov 26, 2025

@aalamsi22 are there BSP changes needed for this PR to work on regular darwin?

I am seeing lots of failure in off-diff test. Regular darwin is running on U-dev rules. As I said, Any changes in regular darwin config should not require new BSP changes. That's the reason why we introduce the darwin_netOS.

This is a regular darwin in the fleet for instance. The path in your PR doesn't exist

[[email protected] ~]# ls /run/devmap/sensors/SC_QSFPDD_IR35223/power3_input
ls: cannot access '/run/devmap/sensors/SC_QSFPDD_IR35223/power3_input': No such file or directory
[[email protected] ~]#

Those are the tests failing.

2025/11/21 13:36:41.639|13927|MainThread|D|paramiko_utils: E1121 13:36:41.599324 1989177 SensorServiceImpl.cpp:198] Could not read data for TH3_VRD1_VIN from path:/run/devmap/sensors/SC_TH3_CORE_IR35223/in1_input, error:File does not exist
E1121 13:36:41.599355 1989177 SensorServiceImpl.cpp:198] Could not read data for TH3_VRD1_VOUT from path:/run/devmap/sensors/SC_TH3_CORE_IR35223/in2_input, error:File does not exist
2025/11/21 13:36:41.644|13927|MainThread|D|paramiko_utils: E1121 13:36:41.599364 1989177 SensorServiceImpl.cpp:198] Could not read data for TH3_VRD1_TEMP from path:/run/devmap/sensors/SC_TH3_CORE_IR35223/temp1_input, error:File does not exist
E1121 13:36:41.599372 1989177 SensorServiceImpl.cpp:198] Could not read data for TH3_VRD1_POUT from path:/run/devmap/sensors/SC_TH3_CORE_IR35223/power2_input, error:File does not exist
E1121 13:36:41.599379 1989177 SensorServiceImpl.cpp:198] Could not read data for TH3_VRD1_IIN from path:/run/devmap/sensors/SC_TH3_CORE_IR35223/curr1_input, error:File does not exist
E1121 13:36:41.599386 1989177 SensorServiceImpl.cpp:198] Could not read data for TH3_VRD1_IOUT from path:/run/devmap/sensors/SC_TH3_CORE_IR35223/curr2_input, error:File does not exist
2025/11/21 13:36:41.649|13927|MainThread|D|paramiko_utils: E1121 13:36:41.599393 1989177 SensorServiceImpl.cpp:198] Could not read data for TH3_VRD2_VIN from path:/run/devmap/sensors/SC_TH3_ANLG_IR35223/in1_input, error:File does not exist
E1121 13:36:41.599400 1989177 SensorServiceImpl.cpp:198] Could not read data for TH3_VRD2_VOUT from path:/run/devmap/sensors/SC_TH3_ANLG_IR35223/in2_input, error:File does not exist
2025/11/21 13:36:41.660|13927|MainThread|D|paramiko_utils: E1121 13:36:41.599415 1989177 SensorServiceImpl.cpp:198] Could not read data for TH3_VRD2_TEMP from path:/run/devmap/sensors/SC_TH3_ANLG_IR35223/temp1_input, error:File does not exist
E1121 13:36:41.599422 1989177 SensorServiceImpl.cpp:198] Could not read data for TH3_VRD2_POUT from path:/run/devmap/sensors/SC_TH3_ANLG_IR35223/power2_input, error:File does not exist
E1121 13:36:41.599428 1989177 SensorServiceImpl.cpp:198] Could not read data for TH3_VRD2_IIN from path:/run/devmap/sensors/SC_TH3_ANLG_IR35223/curr1_input, error:File does not exist
2025/11/21 13:36:41.670|13927|MainThread|D|paramiko_utils: E1121 13:36:41.599435 1989177 SensorServiceImpl.cpp:198] Could not read data for TH3_VRD2_IOUT from path:/run/devmap/sensors/SC_TH3_ANLG_IR35223/curr2_input, error:File does not exist
2025/11/21 13:36:41.670|13927|MainThread|D|paramiko_utils: E1121 13:36:41.599441 1989177 SensorServiceImpl.cpp:198] Could not read data for QSFPDD_VRD_VIN from path:/run/devmap/sensors/SC_QSFPDD_IR35223/in1_input, error:File does not exist
E1121 13:36:41.599450 1989177 SensorServiceImpl.cpp:198] Could not read data for QSFPDD_VRD_VOUT_A from path:/run/devmap/sensors/SC_QSFPDD_IR35223/in2_input, error:File does not exist
2025/11/21 13:36:41.670|13927|MainThread|D|paramiko_utils: E1121 13:36:41.599457 1989177 SensorServiceImpl.cpp:198] Could not read data for QSFPDD_VRD_VOUT_B from path:/run/devmap/sensors/SC_QSFPDD_IR35223/in3_input, error:File does not exist
2025/11/21 13:36:41.675|13927|MainThread|D|paramiko_utils: E1121 13:36:41.599465 1989177 SensorServiceImpl.cpp:198] Could not read data for QSFPDD_VRD_TEMP from path:/run/devmap/sensors/SC_QSFPDD_IR35223/temp1_input, error:File does not exist
2025/11/21 13:36:41.685|13927|MainThread|D|paramiko_utils: E1121 13:36:41.599471 1989177 SensorServiceImpl.cpp:198] Could not read data for QSFPDD_VRD_POUT_A from path:/run/devmap/sensors/SC_QSFPDD_IR35223/power2_input, error:File does not exist
2025/11/21 13:36:41.696|13927|MainThread|D|paramiko_utils: E1121 13:36:41.599480 1989177 SensorServiceImpl.cpp:198] Could not read data for QSFPDD_VRD_POUT_B from path:/run/devmap/sensors/SC_QSFPDD_IR35223/power3_input, error:File does not exist
2025/11/21 13:36:41.701|13927|MainThread|D|paramiko_utils: E1121 13:36:41.599489 1989177 SensorServiceImpl.cpp:198] Could not read data for QSFPDD_VRD_IIN from path:/run/devmap/sensors/SC_QSFPDD_IR35223/curr1_input, error:File does not exist
2025/11/21 13:36:41.706|13927|MainThread|D|paramiko_utils: E1121 13:36:41.599496 1989177 SensorServiceImpl.cpp:198] Could not read data for QSFPDD_VRD_IOUT_A from path:/run/devmap/sensors/SC_QSFPDD_IR35223/curr2_input, error:File does not exist
E1121 13:36:41.599508 1989177 SensorServiceImpl.cpp:198] Could not read data for QSFPDD_VRD_IOUT_B from path:/run/devmap/sensors/SC_QSFPDD_IR35223/curr3_input, error:File does not exist
2025/11/21 13:36:41.716|13927|MainThread|D|paramiko_utils: I1121 13:36:41.599520 1989177 SensorServiceImpl.cpp:96] Processing RACKMON PMUnit: 1 sensors

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 26, 2025

@aalamsi22 has updated the pull request. You must reimport the pull request before landing.

@aalamsi22 aalamsi22 changed the title Darwin: sync sensor_service DARWIN_NETOS: sync sensor_service Dec 2, 2025
@meta-codesync meta-codesync bot closed this in 55f5008 Dec 5, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 5, 2025

@joancaneus merged this pull request in 55f5008.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aalamsi22 @facebook-github-bot @Scott8440 @joancaneus