Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fw_util config file for Darwin48V #351

Closed

Conversation

arajeev-ARISTA
Copy link
Contributor

Summary

fw_util config file for Darwin48V compliant with the recent fw_util refactoring

Testing

Verified fw upgrade/downgrade with fw_util

@facebook-github-bot
Copy link
Contributor

@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Scott8440
Copy link
Contributor

Please double check and verify the file syntax. This fails to pass our internal tests because there is some parsing error with this file. Please add a full test plan with actual pastes/screenshots/etc.

@arajeev-ARISTA
Copy link
Contributor Author

Please double check and verify the file syntax. This fails to pass our internal tests because there is some parsing error with this file. Please add a full test plan with actual pastes/screenshots/etc.

The error is from the chip name GD25Q16(B) as defined in the flashrom source code.

@Scott8440
Copy link
Contributor

The failures from ConfigLib were due to a delimiter just being "()" which caused the string to be closed when this chip name was read. Will merge this PR once my change to ConfigLib is merged.

@Scott8440
Copy link
Contributor

@arajeev-ARISTA I imagine you ran into this problem when testing. In the future can you please include this information in the pull request itself?

@arajeev-ARISTA
Copy link
Contributor Author

@arajeev-ARISTA I imagine you ran into this problem when testing. In the future can you please include this information in the pull request itself?

Will do, thanks!

@facebook-github-bot
Copy link
Contributor

@Scott8440 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Scott8440 merged this pull request in 38eb146.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants