Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Lerna to Nx #7335

Closed
wants to merge 1 commit into from
Closed

Migrate from Lerna to Nx #7335

wants to merge 1 commit into from

Conversation

seyoon20087
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Implements and closes #7333

Test Plan

Implements a new toolset as described in #7333

Test links

Migrating from Lerna to Nx: https://nx.dev/migration/adding-to-monorepo
Comparison: https://nx.dev/guides/lerna-and-nx
Configure Nx to use GitHub Actions (if being used): https://nx.dev/ci/monorepo-ci-github-actions

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

#7333
lerna/lerna#2703

Signed-off-by: Shinwon Elizabeth Yoon <[email protected]>
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 5, 2022
@Josh-Cena
Copy link
Collaborator

Josh-Cena commented May 5, 2022

Sorry I wasn't being super clear 😅 I said my main candidate for now is monodeploy, not Nx. I've updated my comment to make it clearer. We have another PR doing literally the same thing (getting rid of Lerna). Thanks for taking time, though! Really appreciate it.

@Josh-Cena Josh-Cena closed this May 5, 2022
@seyoon20087 seyoon20087 deleted the migrate-to-nx branch May 5, 2022 05:48
@netlify
Copy link

netlify bot commented May 5, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit f3fb9db
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6273635d4c8e0d0008ad72b1
😎 Deploy Preview https://deploy-preview-7335--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Josh-Cena
Copy link
Collaborator

@seyoon20087 I feel bad about closing your PRs, but I think we can discuss a bit more before sending the PR. This way, you don't waste your time.

@github-actions
Copy link

github-actions bot commented May 5, 2022

⚡️ Lighthouse report for the changes in this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 57 🟢 100 🟢 100 🟢 100 🟢 90 View report
/docs/installation 🟠 87 🟢 96 🟢 100 🟢 100 🟢 90 View report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from Lerna to alternative toolset (like Nx)
3 participants