Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(blog): Update Yangshun bio #10942

Merged
merged 3 commits into from
Feb 21, 2025
Merged

misc(blog): Update Yangshun bio #10942

merged 3 commits into from
Feb 21, 2025

Conversation

yangshun
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 21, 2025
Copy link

netlify bot commented Feb 21, 2025

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit dc60417
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/67b85d7a9d353b00083317ec
😎 Deploy Preview https://deploy-preview-10942--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 21, 2025

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 65 🟢 98 🟢 100 🟢 100 Report
/docs/installation 🟠 51 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 73 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 63 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 64 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟠 86 Report

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 👋

You might also want to edit this:

packages/create-docusaurus/templates/shared/blog/authors.yml

Note: adding links here means SEO backlinks coming from many new Docusaurus sites. I'm not sure if the SEO impact is positive (or will always be in the future) considering the default blog posts might be considered duplicates

@yangshun
Copy link
Contributor Author

@slorber Thanks for the tip, updated 😄

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Feb 21, 2025
@slorber slorber merged commit c10a18d into facebook:main Feb 21, 2025
38 checks passed
@yangshun yangshun deleted the patch-1 branch February 21, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants