Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Development builds #13548

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fredlllll
Copy link

It was a fairly easy change of just a few lines to allow the buildscript to interpret the NODE_ENV variable for the environment. if security is your concern, i could also use a different env variable like REACT_NODE_ENV_YES_IM_SURE.

i and many other people have needed this feature for almost 8 years now as evident by this issue #790

it boggles the mind how this is hardcoded to production builds. not every stack is built in a way that enables testing with npm start and then deployment with npm run build. there has to be a way to enable dev/staging builds even if it requires setting silly env vars like mentioned above

please feedback if you want me to change the env var name

@xrentech
Copy link

xrentech commented Apr 2, 2024

I support OP statement, it's a feature especially needed it now.
If we want to enable SSR in our app built initially with CRA, we need to to able to ouput a dev build for the express service in a Dev environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants