-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pixi V8 Upgrade #1495
base: main
Are you sure you want to change the base?
Pixi V8 Upgrade #1495
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ef87bf0 - Browse repository at this point
Copy the full SHA ef87bf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f91923 - Browse repository at this point
Copy the full SHA 4f91923View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcc9e50 - Browse repository at this point
Copy the full SHA dcc9e50View commit details -
Configuration menu - View commit details
-
Copy full SHA for c12c6a9 - Browse repository at this point
Copy the full SHA c12c6a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 489229b - Browse repository at this point
Copy the full SHA 489229bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a255e94 - Browse repository at this point
Copy the full SHA a255e94View commit details -
Configuration menu - View commit details
-
Copy full SHA for d189fb7 - Browse repository at this point
Copy the full SHA d189fb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dc3600 - Browse repository at this point
Copy the full SHA 5dc3600View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3912c96 - Browse repository at this point
Copy the full SHA 3912c96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71e6321 - Browse repository at this point
Copy the full SHA 71e6321View commit details -
Configuration menu - View commit details
-
Copy full SHA for c84c17f - Browse repository at this point
Copy the full SHA c84c17fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 70fdd7d - Browse repository at this point
Copy the full SHA 70fdd7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d40ffe3 - Browse repository at this point
Copy the full SHA d40ffe3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46e9ef9 - Browse repository at this point
Copy the full SHA 46e9ef9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 454c62e - Browse repository at this point
Copy the full SHA 454c62eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 588f5fe - Browse repository at this point
Copy the full SHA 588f5feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f3db22 - Browse repository at this point
Copy the full SHA 7f3db22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c493ff - Browse repository at this point
Copy the full SHA 3c493ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 975e40f - Browse repository at this point
Copy the full SHA 975e40fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1a1fa1 - Browse repository at this point
Copy the full SHA a1a1fa1View commit details -
Working on pixi async init startup
Because Pixi init is async, we need to keep track of that promise, and delay many things until after it has settled.
Configuration menu - View commit details
-
Copy full SHA for ee73c70 - Browse repository at this point
Copy the full SHA ee73c70View commit details -
Configuration menu - View commit details
-
Copy full SHA for b499b8c - Browse repository at this point
Copy the full SHA b499b8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02d4310 - Browse repository at this point
Copy the full SHA 02d4310View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c264e9 - Browse repository at this point
Copy the full SHA 4c264e9View commit details -
- commented out linebuilder for now - commented out dashed lines for now - a few changes in `drawShape()` -> `poly()` - new constructor for `PIXI.Geometry({options})` - pin version to v8.3.3 - move `@esbuild/darwin-arm64` to optionalDependencies - still thinking about how to get texture atlases working
Configuration menu - View commit details
-
Copy full SHA for de61c72 - Browse repository at this point
Copy the full SHA de61c72View commit details -
Configuration menu - View commit details
-
Copy full SHA for e82fb85 - Browse repository at this point
Copy the full SHA e82fb85View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2db882 - Browse repository at this point
Copy the full SHA e2db882View commit details -
Remove enum helpers for pixi line cap/joints, as v8 now just uses the…
… raw string specifiers.
Configuration menu - View commit details
-
Copy full SHA for 52afe07 - Browse repository at this point
Copy the full SHA 52afe07View commit details -
Fix a few issues- beginHole/endHole are replaced by the cut method, a…
…nd maskSource now has a context, not a geometry.
Configuration menu - View commit details
-
Copy full SHA for 6ef1f17 - Browse repository at this point
Copy the full SHA 6ef1f17View commit details -
fix the svgIconToTexture method to just do the symbol allocation with…
…out using resource.load(), which no longer exists.
Configuration menu - View commit details
-
Copy full SHA for 39e932b - Browse repository at this point
Copy the full SHA 39e932bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62fa838 - Browse repository at this point
Copy the full SHA 62fa838View commit details -
Comment out getLabelSprite as it relies on text objects having image …
…data to obtain and allocate in the texture atlas. Bitmap text seems to work!
Configuration menu - View commit details
-
Copy full SHA for 863d749 - Browse repository at this point
Copy the full SHA 863d749View commit details -
Fix a parent-setting bug that was preventing any AbstractFeatures fro…
…m being added to parent containers.
Configuration menu - View commit details
-
Copy full SHA for 7733f73 - Browse repository at this point
Copy the full SHA 7733f73View commit details -
Fix updateHitArea to use a rectangle, which is now one member of the …
…local bounds returned by the sprite.
Configuration menu - View commit details
-
Copy full SHA for 99dbcaa - Browse repository at this point
Copy the full SHA 99dbcaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for c75f101 - Browse repository at this point
Copy the full SHA c75f101View commit details -
Change order of draw calls and swap setStrokeStyle() for just stroke(…
…), lines now appear
Configuration menu - View commit details
-
Copy full SHA for e1b7f2c - Browse repository at this point
Copy the full SHA e1b7f2cView commit details -
setStrokeStyle changes to stroke, beginFill changed to fill, drawCirc…
…le changed to circle, name changed to label, drawRect changed to rect, drawPolygon changed to poly
Configuration menu - View commit details
-
Copy full SHA for 2193f2b - Browse repository at this point
Copy the full SHA 2193f2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d875ec2 - Browse repository at this point
Copy the full SHA d875ec2View commit details -
Fix the lasso drawing code by using poly() instead of polygon() and c…
…orrecting the fill input.
Configuration menu - View commit details
-
Copy full SHA for 9bfd404 - Browse repository at this point
Copy the full SHA 9bfd404View commit details -
Update texture creation code so that fill() and stroke() methods are …
…called after the geometry-creating methods.
Configuration menu - View commit details
-
Copy full SHA for 26d75d9 - Browse repository at this point
Copy the full SHA 26d75d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d66f29 - Browse repository at this point
Copy the full SHA 0d66f29View commit details -
Fix background imagery allocator to include the width and height of e…
…ach allocated texture.
Configuration menu - View commit details
-
Copy full SHA for 98830c1 - Browse repository at this point
Copy the full SHA 98830c1View commit details -
Fix stroke styles and get the atlas allocator quasi-working for just …
…background tiles.
Configuration menu - View commit details
-
Copy full SHA for 8325c2e - Browse repository at this point
Copy the full SHA 8325c2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f36993 - Browse repository at this point
Copy the full SHA 9f36993View commit details -
Fix call to photoSystem.render() that was causing a stack trace
Benjamin Clark committedSep 17, 2024 Configuration menu - View commit details
-
Copy full SHA for 82352d4 - Browse repository at this point
Copy the full SHA 82352d4View commit details
Commits on Sep 18, 2024
-
Update dependencies, pin to pixi 8.4.0
Note that we do not need the submodules anymore (maybe we did not before either) `@pixi/util`, `@pixi/display`, `@pixi/graphics`, etc These things are all bundled in `pixijs` `@pixi/settings` is removed in v8
Configuration menu - View commit details
-
Copy full SHA for 391c12b - Browse repository at this point
Copy the full SHA 391c12bView commit details -
Update more of the graphic drawing methods to v8
This is stuff like - drawCircle -> circle - drawRectangle -> rect - drawPolygon -> poly Also, be more consistent in how we import the Pixi objects, prefer just using the star import everywhere: `import * as PIXI from 'pixi.js';`
Configuration menu - View commit details
-
Copy full SHA for 806de77 - Browse repository at this point
Copy the full SHA 806de77View commit details -
Revert the experimental code that was added to the tile layer
This was unnecessary, the AtlasAllocator can continue to deal with whatever texture sources inputs we send it.
Configuration menu - View commit details
-
Copy full SHA for b2e43dc - Browse repository at this point
Copy the full SHA b2e43dcView commit details -
Skip the build worflow for this branch for now
It won't work because: "@rapideditor/pixi-dashed-line": "file:../pixi-dashed-line", "@rapideditor/pixi-texture-allocator": "file:../pixi-texture-allocator",
Configuration menu - View commit details
-
Copy full SHA for 6304197 - Browse repository at this point
Copy the full SHA 6304197View commit details
Commits on Sep 19, 2024
-
More Pixi v8 work, atlas textures seem to work now
- Added several render options at init that might be helping - Commented out the `graphicToTexture code` - Several renames from `getChildByName` -> `getChildByLabel` Also, be more consistent in how we import the Pixi objects, prefer just using the star import everywhere: `import * as PIXI from 'pixi.js';`
Configuration menu - View commit details
-
Copy full SHA for 1ce0237 - Browse repository at this point
Copy the full SHA 1ce0237View commit details -
Configuration menu - View commit details
-
Copy full SHA for e353b8a - Browse repository at this point
Copy the full SHA e353b8aView commit details
Commits on Sep 20, 2024
-
Replace default ticker listener as before
The variables are a little different in v8. This is still hacky, but I'm not sure another way around it. The `TickerPlugin` code that adds the Ticker to `PIXI.Application` really wants to do `ticker.add(this.render, this, UPDATE_PRIORITY.LOW);` even if we were to replace it with a different Ticker. Our issue is we need to call `render` ourselves at the time of our choosing.
Configuration menu - View commit details
-
Copy full SHA for 39eba45 - Browse repository at this point
Copy the full SHA 39eba45View commit details -
Update the svgIconToTexture method for v8.
Benjamin Clark committedSep 20, 2024 Configuration menu - View commit details
-
Copy full SHA for 8307eee - Browse repository at this point
Copy the full SHA 8307eeeView commit details
Commits on Sep 23, 2024
-
WIP on textures and bitmap font issues
Our texture atlases seem to be getting corrupted. This will show up as either the Bitmap Fonts getting messed up, or leaking into the background tiles. I've tried commenting out the minimap for now, and also doing some other cleanups around the code to isolate whether textures are getting destroyed propertly.
Configuration menu - View commit details
-
Copy full SHA for 665391e - Browse repository at this point
Copy the full SHA 665391eView commit details -
Replaced the AtlasAllocator code
This switches from using `@rapideditor/pixi-texture-allocator` "fork of the plugin" to just including the code we need in Rapid. The old code worked ok for v7, but the v8 upgrade was causing texture corruption, and it became easier to just massively simplify things than to debug and fix whatever was going on with the plugin code.
Configuration menu - View commit details
-
Copy full SHA for 3feb687 - Browse repository at this point
Copy the full SHA 3feb687View commit details
Commits on Sep 24, 2024
-
Disable half pixel texture correction, as it now causes seams
Also passing more options in the AtlasSource/TextureSource constructor, preferring to leave nothing to chance here. Also add some more comments and make sure everything has labels for better debug-ability.
Configuration menu - View commit details
-
Copy full SHA for 8ca2a12 - Browse repository at this point
Copy the full SHA 8ca2a12View commit details -
Rasterize the SVG icons by setting them onto an Image
This is an older trick that I removed in dd24e91 In pixi v7, we switched to using `SVGResource`, which did this for us In pixi v8, `SVGResource` is gone and there is now a SVG parser, but it doesn't fully support svg syntax, so we can go back to the old way for now.
Configuration menu - View commit details
-
Copy full SHA for 1de84a0 - Browse repository at this point
Copy the full SHA 1de84a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6aa505 - Browse repository at this point
Copy the full SHA b6aa505View commit details -
If no options are supplied to graphicToTexture, make an empty object.
Benjamin Clark committedSep 24, 2024 Configuration menu - View commit details
-
Copy full SHA for 6c8992e - Browse repository at this point
Copy the full SHA 6c8992eView commit details
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 299b6a3 - Browse repository at this point
Copy the full SHA 299b6a3View commit details -
- Uncomments the `PixiLayerLabels` layer - Restores both bitmap text (ascii text placed next to pins) and textured text (complex text next to pins or along ropes) - Moves the text-to-texture code from `PixiLayerLabels.getLabelSprite()` to `PixiTextures.textToTexture()` in the texture manager (there are other functions in texture manager like this) Todo: - Polygon labels remain commented out because we need to calculate the buffer inside the perimeter. We were (ab)using `PIXI.buildLine` for this, but maybe there is a better way now.. Also: - There was previously some code in `PixiLayerLabels` that would do `toGlobal(position, point, true)` to skip updating the transform We can not pass `true` for `skipUpdate` anymore in pixi v8, Probably related to pixijs/pixijs#10433
Configuration menu - View commit details
-
Copy full SHA for d24aa79 - Browse repository at this point
Copy the full SHA d24aa79View commit details -
Fix
PIXI.buildLine()
for v8 and restore perimeter area labelsThis was used before for calculating buffers around lines, which was used for hit testing and label placement.
Configuration menu - View commit details
-
Copy full SHA for 18355f8 - Browse repository at this point
Copy the full SHA 18355f8View commit details
Commits on Sep 26, 2024
-
Get dashed lines back to working for polygons/lines.
Benjamin Clark committedSep 26, 2024 Configuration menu - View commit details
-
Copy full SHA for ad3710d - Browse repository at this point
Copy the full SHA ad3710dView commit details
Commits on Sep 27, 2024
-
Changes to support webGPU- move the UiDefs svg code to load after pix…
…i has started, and change the allocator to send ImageBitmaps instead of raw pixel arrays.
Benjamin Clark committedSep 27, 2024 Configuration menu - View commit details
-
Copy full SHA for 8afe728 - Browse repository at this point
Copy the full SHA 8afe728View commit details
Commits on Sep 28, 2024
-
Got polygon partial fills working again
I went back to doing things the old way: - Make a `PIXI.Graphic` using strokes, Then force generate it’s geometry, Then and extract the geometry into a `PIXI.Mesh`. The mesh works well for both hit testing and masking. Other approaches that didn't work: - In Pixi v8, stroke graphics can work for hit testing, but the hit test ignores `alignment` which we need when partial filling. - Tried using our `lineToPoly` buffer generating function to convert the stroke into a Graphic that would both hit test and mask, but it's too buggy. (it uses pixi's linebuilder, then walks the perimeter)
Configuration menu - View commit details
-
Copy full SHA for cb0809c - Browse repository at this point
Copy the full SHA cb0809cView commit details