Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve minValue & maxValue actions and add missing test cases #843

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

improve minValue & maxValue actions and add missing test cases #843

wants to merge 2 commits into from

Conversation

EltonLobo07
Copy link
Contributor

Both of the actions will add an issue when dataset.value is NaN.

@EltonLobo07
improve maxValue action and add "non-..." test cases
f2b65bd 
Improvement:
    `maxValue` should add an issue when
    `dataset.value` is `NaN`
@EltonLobo07
improve minValue action and add "non-..." test cases
ce318fa 
Improvement:
    `minValue` should add an issue when
    `dataset.value` is `NaN`
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 20, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/valibot@843

commit: ce318fa

@fabian-hiller fabian-hiller self-assigned this Sep 21, 2024
@fabian-hiller fabian-hiller added the enhancement New feature or request label Sep 21, 2024
@fabian-hiller
Copy link
Owner

Thank you! I will try to review and merge it on the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabian-hiller fabian-hiller

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EltonLobo07 @fabian-hiller