Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizable injection point #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Preston-Landers
Copy link

For my use case it's very handy to be able to control the injection point, rather than always at the end of the </head> tag. This change allows you to choose a different injection point.

My reasoning is that sometimes I need to include my own CSS files after a Bower component so the CSS rendering rules prioritize my styles given the same specifier. I think this can probably be accomplished by making all my CSS files a bowerstatic local component, but I prefer having the flexibility over the inclusion point.

@faassen
Copy link
Owner

faassen commented Jul 21, 2015

Looks like a good patch, but it also needs tests. There is some tricky fallback logic here which uses the </head> after all if the injection point cannot be found.

We also need some documentation improvements to document this.

@Preston-Landers
Copy link
Author

Cool. I'll look into some testing and the docs. Honestly I'm not sure the fallback logic is really necessary - and it isn't needed for my personal purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants