Skip to content

Conversation

@mwestphal
Copy link
Member

@mwestphal mwestphal commented Dec 24, 2025

Describe your changes

  • Add scene::add(void* ptr, std::size_t size) API to read file from memory
  • Add supports in F3D to read from the input stream (std::cin) by reading the - file
  • Add testing logic and tests for all formats the support reading from memory, default conf and invalid
  • Add SDKTest for error code path
  • split gltf/glb reader into two different readers for the binary stream identification
  • Add python/c/java/wasm binding for the new add method and tests on python/c/java
  • Takes VTK_VERSION into account to enable supports streaming or not
  • Update doc about format support, - usage, plugins and more
  • Add stream support in --list-readers

TODO

  • update once VTK MR are merged (9.6.20269999)
  • remove debug gdb code

Status:

  • VTKLegacy: OK : 9.6.X
  • VTKXMLVT*: OK : 9.6.X
  • VTKHDF: OK :
  • ExodusII: NO -> unsupported
  • NetCDF: OK
  • PLYReader: OK
  • STL: OK
  • DICOM: OK
  • Nrrd: NO -> unsupported
  • MetaImage: NO -> unsupported
  • TIFF: NO -> unsupported
  • QuakeMDL: OK
  • CityGML: OK
  • PTS: OK
  • STEP: OK
  • IGES: NO -> unsupported
  • BREP: OK (brep and bin.brep)
  • XBF: OK
  • Alembic: OK
  • OBJ: OK
  • GLB: OK (no mdl)
  • GLTF: OK (no external URI)
  • Draco: OK
  • 3DS: OK
  • VRML: NO
  • FBX: OK
  • COLLADA: OK
  • OFF: OK
  • DXF: OK
  • DirectX: OK
  • 3MF: OK
  • USD: NO -> yet to implement
  • VDB: OK
  • Splat: OK
  • SPZ: OK

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@github-actions
Copy link

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: c, python, java, webassembly.

@mwestphal mwestphal changed the title Quick and dirty piped stream reading Add support for reading streams Dec 30, 2025
@mwestphal mwestphal marked this pull request as ready for review December 30, 2025 18:18
@mwestphal mwestphal added ci:full and removed ci:fast labels Dec 30, 2025
@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 98.75000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.69%. Comparing base (1957300) to head (4d389e8).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
application/F3DStarter.cxx 97.43% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2754      +/-   ##
==========================================
+ Coverage   96.66%   96.69%   +0.02%     
==========================================
  Files         142      150       +8     
  Lines       12810    12926     +116     
==========================================
+ Hits        12383    12499     +116     
  Misses        427      427              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwestphal mwestphal requested review from Meakk and snoyer December 31, 2025 11:53
@mwestphal mwestphal added this to the 3.5.0 milestone Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant