Skip to content

Conversation

@Meakk
Copy link
Member

@Meakk Meakk commented Dec 24, 2025

Describe your changes

On Android, caches are local to app, so it's the app responsibility to set the cache path using f3d::engine::setCachePath right after engine initialization.
Do not throw if the cache path cannot be retrieved using env vars.

Supersedes #2024

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@Meakk Meakk self-assigned this Dec 24, 2025
@Meakk Meakk added the ci:full label Dec 24, 2025
@Meakk Meakk mentioned this pull request Dec 24, 2025
@Meakk Meakk changed the title Do not throw if cache is empty Do not throw if cache path is empty Dec 24, 2025
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is surely a test to update.

Also, what is the behavior when there is no cache path then ?

@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.59%. Comparing base (d4869e9) to head (24e6fe3).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2752      +/-   ##
==========================================
- Coverage   96.61%   96.59%   -0.03%     
==========================================
  Files         142      142              
  Lines       12731    12736       +5     
==========================================
+ Hits        12300    12302       +2     
- Misses        431      434       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants