Draft: Added Support for TimeSteps in vtkF3DGenericImporter #2749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestphal
reviewed
Dec 24, 2025
mwestphal
reviewed
Dec 24, 2025
mwestphal
reviewed
Dec 24, 2025
mwestphal
reviewed
Dec 24, 2025
mwestphal
reviewed
Dec 24, 2025
mwestphal
reviewed
Dec 24, 2025
mwestphal
reviewed
Dec 24, 2025
vishnukoushik143
force-pushed
the
issue2733
branch
from
9f8906a to
ce30d86
Compare
mwestphal
reviewed
Dec 24, 2025
mwestphal
reviewed
Dec 24, 2025
mwestphal
requested changes
Dec 24, 2025
Member
mwestphal
left a comment
mwestphal
left a comment
There was a problem hiding this comment.
nice, please add a test for this in vtkext/private/module/Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added Two more members to store the TimeSteps and NumberOfTimeSteps in vtkF3DGenericImporter class's Internals struct.
Modified GetTemporalInformation and UpdateTemporalInformation methods of the class accordingly.
Issue ticket number and link if any
#2733
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.