Add progress report for vtkF3DAssimpImporter
#2703
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hy-LeTuan
changed the title
vtkF3DAssimpImporter
Contributor
Author
|
@mwestphal could you check this out please? |
mwestphal
reviewed
Dec 9, 2025
mwestphal
reviewed
Dec 9, 2025
mwestphal
reviewed
Dec 9, 2025
mwestphal
reviewed
Dec 9, 2025
mwestphal
reviewed
Dec 9, 2025
mwestphal
reviewed
Dec 11, 2025
Member
|
Hi @Hy-LeTuan Need any help moving forward ? |
Contributor
Author
|
I think everything is all done? All tests passed on my machine |
Member
Ill review, next time please ping me when you need a review :) |
Contributor
Author
|
Yes sir I'll ping you next time! |
Member
|
\ci full |
Member
|
Looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add progress reporting to
vtkF3DAssimpImporterin the Assimp plugin through attaching a derived class ofAssimp::ProgressHandleron the native Assimp reporter and use the parent importer to invoke progress report event.Continuation of this issue: #22