-
-
Notifications
You must be signed in to change notification settings - Fork 358
Volume Opacity Control #2693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Volume Opacity Control #2693
Conversation
|
You are modifying libf3d public API! |
|
\ci fast |
|
tests and documentation will be added later. |
|
@mwestphal Hi, this is ready for review |
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flag related changes
please add tests and docs
CI is red :)
|
Please rebase on master to fix website CI |
|
\ci full |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2693 +/- ##
==========================================
- Coverage 96.67% 96.65% -0.02%
==========================================
Files 142 142
Lines 12833 12874 +41
==========================================
+ Hits 12406 12444 +38
- Misses 427 430 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Describe your changes
Update opacity control for the volume rendering
Opacity file to test (gaussian curve):

Issue ticket number and link if any
#2052
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.