Skip to content

Conversation

@AoGao-Kedoka
Copy link
Contributor

@AoGao-Kedoka AoGao-Kedoka commented Dec 3, 2025

Describe your changes

Update opacity control for the volume rendering

Opacity file to test (gaussian curve):
gaussian_opacity_map

Issue ticket number and link if any

#2052

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

@AoGao-Kedoka
Copy link
Contributor Author

\ci fast

@AoGao-Kedoka
Copy link
Contributor Author

AoGao-Kedoka commented Dec 3, 2025

tests and documentation will be added later.

@AoGao-Kedoka
Copy link
Contributor Author

@mwestphal Hi, this is ready for review

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes needed

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flag related changes

please add tests and docs

CI is red :)

@mwestphal
Copy link
Member

Please rebase on master to fix website CI

@AoGao-Kedoka
Copy link
Contributor Author

\ci full

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

❌ Patch coverage is 90.47619% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.65%. Comparing base (9b0865f) to head (e3323d3).

Files with missing lines Patch % Lines
vtkext/private/module/vtkF3DRenderer.cxx 87.09% 4 Missing ⚠️
application/F3DStarter.cxx 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2693      +/-   ##
==========================================
- Coverage   96.67%   96.65%   -0.02%     
==========================================
  Files         142      142              
  Lines       12833    12874      +41     
==========================================
+ Hits        12406    12444      +38     
- Misses        427      430       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants