Skip to content

Conversation

@Meakk
Copy link
Member

@Meakk Meakk commented Nov 13, 2025

Describe your changes

  • Implement many splats types

Issue ticket number and link if any

Fixes #1272

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@Meakk Meakk self-assigned this Nov 13, 2025
@Meakk Meakk marked this pull request as draft November 13, 2025 22:57
@Meakk Meakk added the ci:fast label Nov 27, 2025
@Meakk Meakk marked this pull request as ready for review November 27, 2025 08:42
@Meakk Meakk added ci:full and removed ci:fast labels Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.53%. Comparing base (50f1f0c) to head (98eeb5f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2624      +/-   ##
==========================================
- Coverage   96.54%   96.53%   -0.02%     
==========================================
  Files         141      141              
  Lines       12481    12512      +31     
==========================================
+ Hits        12050    12078      +28     
- Misses        431      434       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Meakk Meakk force-pushed the improve-splats branch 3 times, most recently from 9960893 to 98eeb5f Compare December 2, 2025 09:09
@Meakk Meakk changed the title Improve splats Add more point sprite types Dec 2, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Style Checks CI failed:

diff --git a/library/src/interactor_impl.cxx b/library/src/interactor_impl.cxx
index f1139f5..bb19d4d 100644
--- a/library/src/interactor_impl.cxx
+++ b/library/src/interactor_impl.cxx
@@ -1059,9 +1059,8 @@ interactor& interactor_impl::initCommands()
     {
       bool& enabled = this->Internals->Options.model.point_sprites.enable;
       std::string& type = this->Internals->Options.model.point_sprites.type;
-      constexpr std::array<std::string_view, 8> validTypes = {
-        "sphere", "gaussian", "circle", "stddev", "flow", "bound", "cross"
-      };
+      constexpr std::array<std::string_view, 8> validTypes = { "sphere", "gaussian", "circle",
+        "stddev", "flow", "bound", "cross" };
       if (!enabled)
       {
         enabled = true;
@@ -1069,7 +1068,8 @@ interactor& interactor_impl::initCommands()
       }
       else
       {
-        auto index = std::distance(std::begin(validTypes), std::find(std::begin(validTypes), std::end(validTypes), type));
+        auto index = std::distance(
+          std::begin(validTypes), std::find(std::begin(validTypes), std::end(validTypes), type));
         if (index == 6) // last type
         {
           enabled = false;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More point splats shaders

1 participant