Skip to content

Conversation

@davidwuluetang
Copy link

Describe your changes

  • Implement auto font scaling on file vtkF3DRenderer.cxx under vtkF3DRenderer::ConfigureTextActors()
  • Update doc new_release.md
  • Update doc 03-OPTIONS.md

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

CI not testable

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

questions and changes

@davidwuluetang
Copy link
Author

Changes made. I remove the note on 03-OPTIONS.md under --font-scale=<ratio> since I not messing with font scale value. Let me know if I should mention anything about it.

@mwestphal mwestphal self-requested a review November 16, 2025 16:40
@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.53%. Comparing base (36147c4) to head (49972f4).
⚠️ Report is 77 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2623      +/-   ##
==========================================
+ Coverage   96.49%   96.53%   +0.03%     
==========================================
  Files         140      141       +1     
  Lines       12180    12509     +329     
==========================================
+ Hits        11753    12075     +322     
- Misses        427      434       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me, but I defer to @Meakk

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there, just a doc changes needed :)

@mwestphal mwestphal requested a review from Meakk December 11, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants