Addition of --axesGrid option #2100
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| this->CubeAxesActor->GetLabelTextProperty(1)->SetColor(up); | ||
| this->CubeAxesActor->GetTitleTextProperty(1)->SetColor(up); | ||
| this->CubeAxesActor->GetLabelTextProperty(2)->SetColor(front); | ||
| this->CubeAxesActor->GetTitleTextProperty(2)->SetColor(front); |
There was a problem hiding this comment.
this color code seems incorrect
There was a problem hiding this comment.
Would you mind explaining which part is incorrect?
I matched the axes colours against the grid (shortcut g)
There was a problem hiding this comment.
You use the right/up/front vector as colors, resulting in pure red and green in the grid, im not sure this is intended ?
There was a problem hiding this comment.
I just took the idea from line 699-700 within vtkF3DRenderer.cxx, where the grid colour is set.
gridMapper->SetAxis1Color(::abs(right[0]), ::abs(right[1]), ::abs(right[2]), 1);
gridMapper->SetAxis2Color(::abs(front[0]), ::abs(front[1]), ::abs(front[2]), 1);
Do you have any suggestions for colours? Perhaps if there are any colours defined anywhere I could take them.
There was a problem hiding this comment.
Im not sure we want the full cage, what about trying to get something similar to this: #7 ?
There was a problem hiding this comment.
I have updated the styling to closer match the grid.
Only thing I cannot achieve is the occlusion of the axis that is closest to the camera/obscuring view of the model
|
You are modifying libf3d public API! |
|
Looks like your rebase/merge with master did not work as you expected, let me know if you need help with that :) |
library/options.json
Outdated
| "axes_grid": { | ||
| "enable": { | ||
| "type": "bool", | ||
| "default_value": "false" | ||
| } | ||
| }, |
There was a problem hiding this comment.
| "axes_grid": { | |
| "enable": { | |
| "type": "bool", | |
| "default_value": "false" | |
| } | |
| }, | |
| "axes_grid": { | |
| "enable": { | |
| "type": "bool", | |
| "default_value": "false" | |
| } | |
| }, |
# Conflicts: # vtkext/private/module/vtkF3DRenderer.cxx # vtkext/private/module/vtkF3DRenderer.h
…alter variable names to match. Match styling of grid closer to suggestion
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Added command line argument --axesGrid which maps to render.cubeAxis.enable.
Support showing the vtkCubeAxesActor within the viewport, matching to bounding box of the model.
Added application layer test for this option.
Issues #7