Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli reader options #1860

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

0xfedcafe
Copy link
Contributor

Added a CLI reader option #1735

Copy link

github-actions bot commented Jan 3, 2025

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.59%. Comparing base (8d72f2d) to head (bc26894).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1860   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files         125      125           
  Lines       10013    10015    +2     
=======================================
+ Hits         9572     9574    +2     
  Misses        441      441           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -65,6 +65,7 @@ static inline const std::array<CLIGroup, 8> CLIOptions = {{
{ "no-background", "", "No background when render to file", "<bool>", "1" },
{ "help", "h", "Print help", "", "" }, { "version", "", "Print version details", "", "" },
{ "list-readers", "", "Print the list of readers", "", "" },
{"force-reader", "", "Enforce a specific reader", "<reader>", "1"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an application test

@mwestphal
Copy link
Contributor

Do you need any help or review to move forward @0xfedcafe ?

@0xfedcafe
Copy link
Contributor Author

Do you need any help or review to move forward @0xfedcafe ?

Just that upper question about an optional and I’ll push hopefully the final commit for this task with the test

@mwestphal
Copy link
Contributor

Hi @0xfedcafe

How is it going ? Do you need any help ?

@mwestphal mwestphal linked an issue Mar 1, 2025 that may be closed by this pull request
@mwestphal
Copy link
Contributor

Hi @0xfedcafe

Please do not hesitate to reach out if you need any guidance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a CLI option to select reader to use
2 participants