Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56
This replaces
coffee/omelette.coffee
withtypescript/omelette.ts
Some notes:
src/omelette.js
, rather than trying to match the coffee source to typescripttypescript
as a dev dependency.gitignore
containingnode_modules
and apnpm-lock.yaml
tsconfig.json
(strict
is enabled though this required using one non-null assertion (this.word!
)build
script to package.jsontypes
field to package.jsontest/test-d.ts
file to make sure the types don't regress, copying from https://github.com/DefinitelyTyped/DefinitelyTyped/blob/26b0538e9b3cd7498827609a59c09eb5a2fdd58b/types/omelette/omelette-tests.tstest
script to package.json which currently just compiles the types test fileStuff I didn't change:
src/omelette.js
folder, even though it's generated fromtypescript/omelette.ts
- keeping under source control is somewhat unconventional but it's equivalent to how it was with Coffeescriptsrc/
, usually that would be for the "source" code (typescript/coffee), and the output would be indist/
orlib/
. But not a big deal so I left it.Any/all of those could come after, but I don't see them as problems per se - esp if updates to this repo aren't too frequent and releases are manual.
Review notes:
src/omelette.js
rather thantypescript/omelette.ts
(you'll need to "show large diffs" and will want to ignore whitespace changes if viewing on github)Testing: