-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latex Puritains #50
Latex Puritains #50
Conversation
Books still not booking yet.
inspiration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would like for the booklet to also work with this, so please finish that before you merge this pr, i would like to review it again.
also with makefile changes, i would like for the nix flake to also be updated, please apply this change
diff --git a/flake.nix b/flake.nix
index ad27c87..f607601 100644
--- a/flake.nix
+++ b/flake.nix
@@ -16,8 +16,8 @@
installPhase = ''
mkdir -p $out/{bin,share}
${pkgs.gnumake}/bin/make booklet
- mv main_book.pdf $out/share
- echo "${pkgs.xdg-utils}/bin/xdg-open $out/share/main_book.pdf" > $out/bin/${builtins.replaceStrings [" "] ["-"] name}
+ mv output/booklet.pdf $out/share
+ echo "${pkgs.xdg-utils}/bin/xdg-open $out/share/booklet.pdf" > $out/bin/${builtins.replaceStrings [" "] ["-"] name}
chmod +x $out/bin/${builtins.replaceStrings [" "] ["-"] name}
'';
};
@@ -27,9 +27,9 @@
nativeBuildInputs = deps;
installPhase = ''
mkdir -p $out/{bin,share}
- ${pkgs.gnumake}/bin/make pdf
- mv main.pdf $out/share
- echo "${pkgs.xdg-utils}/bin/xdg-open $out/share/main.pdf" > $out/bin/${builtins.replaceStrings [" "] ["-"] name}
+ ${pkgs.gnumake}/bin/make kontinuert
+ mv output/kontinuert.pdf $out/share
+ echo "${pkgs.xdg-utils}/bin/xdg-open $out/share/kontinuert.pdf" > $out/bin/${builtins.replaceStrings [" "] ["-"] name}
chmod +x $out/bin/${builtins.replaceStrings [" "] ["-"] name}
'';
sat det ind som du skrev booklet delen er stadig "nonfunctional" rent tex-messigt |
@Mast3rwaf1z du må btw gerne lave commits hehe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i want to take a look at booklet then, but please fix these from the changes to the nix flake
maybe we can look into fixing the booklet and CI together at some point? |
Co-authored-by: Thomas Jensen <[email protected]>
Co-authored-by: Thomas Jensen <[email protected]>
…into latex-puritans
Har testet det med printern. it works like a charm. Så det bare CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good on my machine, great job 👍
when i make the booklet, every other page is upside down, which doesn't matter for print but it would be really nice if it was possible to fix that, doesn't have to be in this pr, i'm just happy it works now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you fix ci?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk, har aldrig leget med det før
Books still not booking yet.