Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latex Puritains #50

Merged
merged 13 commits into from
Mar 19, 2025
Merged

Latex Puritains #50

merged 13 commits into from
Mar 19, 2025

Conversation

Naitsabot
Copy link
Contributor

Books still not booking yet.

Books still not booking yet.
@Naitsabot Naitsabot requested a review from Mast3rwaf1z March 16, 2025 16:30
@Naitsabot
Copy link
Contributor Author

inspiration
https://tex.stackexchange.com/a/126792

Copy link
Member

@Mast3rwaf1z Mast3rwaf1z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would like for the booklet to also work with this, so please finish that before you merge this pr, i would like to review it again.

also with makefile changes, i would like for the nix flake to also be updated, please apply this change

diff --git a/flake.nix b/flake.nix
index ad27c87..f607601 100644
--- a/flake.nix
+++ b/flake.nix
@@ -16,8 +16,8 @@
             installPhase = ''
                 mkdir -p $out/{bin,share}
                 ${pkgs.gnumake}/bin/make booklet
-                mv main_book.pdf $out/share
-                echo "${pkgs.xdg-utils}/bin/xdg-open $out/share/main_book.pdf" > $out/bin/${builtins.replaceStrings [" "] ["-"] name}
+                mv output/booklet.pdf $out/share
+                echo "${pkgs.xdg-utils}/bin/xdg-open $out/share/booklet.pdf" > $out/bin/${builtins.replaceStrings [" "] ["-"] name}
                 chmod +x $out/bin/${builtins.replaceStrings [" "] ["-"] name}
             '';
         };
@@ -27,9 +27,9 @@
             nativeBuildInputs = deps;
             installPhase = ''
                 mkdir -p $out/{bin,share}
-                ${pkgs.gnumake}/bin/make pdf
-                mv main.pdf $out/share
-                echo "${pkgs.xdg-utils}/bin/xdg-open $out/share/main.pdf" > $out/bin/${builtins.replaceStrings [" "] ["-"] name}
+                ${pkgs.gnumake}/bin/make kontinuert
+                mv output/kontinuert.pdf $out/share
+                echo "${pkgs.xdg-utils}/bin/xdg-open $out/share/kontinuert.pdf" > $out/bin/${builtins.replaceStrings [" "] ["-"] name}
                 chmod +x $out/bin/${builtins.replaceStrings [" "] ["-"] name}
             '';

@Naitsabot
Copy link
Contributor Author

#50 (review)

sat det ind som du skrev

booklet delen er stadig "nonfunctional" rent tex-messigt

@Naitsabot Naitsabot requested a review from Mast3rwaf1z March 16, 2025 21:45
@Naitsabot
Copy link
Contributor Author

@Mast3rwaf1z du må btw gerne lave commits hehe

@Naitsabot Naitsabot added the enhancement New feature or request label Mar 16, 2025
@Naitsabot
Copy link
Contributor Author

Issues det (måske/måske ikke) fixer: #45 #44

@Mast3rwaf1z
Copy link
Member

Issues det (måske/måske ikke) fixer: #45 #44

#45 kræver at CI virker

Copy link
Member

@Mast3rwaf1z Mast3rwaf1z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want to take a look at booklet then, but please fix these from the changes to the nix flake

@Mast3rwaf1z
Copy link
Member

maybe we can look into fixing the booklet and CI together at some point?

@Naitsabot
Copy link
Contributor Author

Har testet det med printern. it works like a charm. Så det bare CI

Copy link
Member

@Mast3rwaf1z Mast3rwaf1z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good on my machine, great job 👍

when i make the booklet, every other page is upside down, which doesn't matter for print but it would be really nice if it was possible to fix that, doesn't have to be in this pr, i'm just happy it works now!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix ci?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk, har aldrig leget med det før

@Naitsabot Naitsabot merged commit 5b1384c into main Mar 19, 2025
1 check failed
@krestenlaust krestenlaust deleted the latex-puritans branch March 20, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants