New functionality for giphy input and display #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred-bowker
commented
Jan 25, 2025
| tabBar.frame.size.height | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
one of the requirements for getting your app approved to use the giphySDK is that you show an attribution mark. This requirement is not very well specified on the giphy sdk docs, however including this small image overlay on the picker meets the requirement
fred-bowker
commented
Jan 25, 2025
fred-bowker
commented
Jan 25, 2025
Sources/ExyteChat/Resources/Media.xcassets/InputView/sticker.imageset/sticker.png
Outdated
Show resolved
Hide resolved
fred-bowker
commented
Jan 25, 2025
fred-bowker
commented
Jan 25, 2025
f3dm76
requested changes
Feb 3, 2025
| @@ -10,42 +10,42 @@ import ExyteMediaPicker | |||
| import ActivityIndicatorView | |||
|
|
|||
| struct AttachmentsEditor<InputViewContent: View>: View { | |||
|
|
|||
There was a problem hiding this comment.
Please don't add these, this can be changed in xcode settings
There was a problem hiding this comment.
It would be good to see about getting #126 merged, that way I could just run the command to meet the projects formatting, I've added another commit, with the correct formatting so this should now be fixed
fred-bowker
commented
Feb 3, 2025
… fred-bowker-1 # Conflicts: # Sources/ExyteChat/ChatView/Attachments/AttachmentsEditor.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.