draft of use_crate() #361
draft of use_crate() #361
Conversation
|
|
||
| cli::cli_abort( | ||
| "{.var features} should be a character vector.", | ||
| "i" = "You supplied an object of class {class(features)}.", |
There was a problem hiding this comment.
this class() call should grab the first element of the output. There may be 1 or more classes
There was a problem hiding this comment.
good point. are you thinking class(x)[1] or is there a better way?
There was a problem hiding this comment.
that works for me! We could also utilize the obj_type_friendly() standalone function.
https://github.com/r-lib/rlang/blob/main/R/standalone-obj-type.R
|
|
||
| cli::cli_abort( | ||
| "{.var git} should be a length one character vector.", | ||
| "i" = "You supplied an object of class {class(git)} with length {length(git)}.", |
|
|
||
| cli::cli_abort( | ||
| "{.var version} should be a length one character vector.", | ||
| "i" = "You supplied an object of class {class(version)} with length {length(version)}.", |
| lst <- rlang::dots_list(...) | ||
|
|
||
| if (length(lst) > 0){ names(lst) <- paste0("--", names(lst)) } |
There was a problem hiding this comment.
this part might be odd. this would probably need to be better described in the params and with an example. like optional = TRUE becomes --optional true
There was a problem hiding this comment.
there are also flags that don't take a value, like --dev. i wasn't sure how to handle those...
For #360