-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- a little hack to enable custom request decryption #86
base: master
Are you sure you want to change the base?
Conversation
vietanh85
commented
Mar 25, 2015
- Sometime we need to encrypt response and request from client to server to ensure security
Makes sense. Can the decryption be done as a stream instead of a sync decryption? |
Since, we are using raw-body to convert request stream to a buffer. In addition, I've learned that, there is no way to modify a readable stream in nodejs. So I think we cannot decrypt a stream. |
I'm talking about changing the interface here to take a TransformStream, rather than do it prior to calling this module. |
Ok, sorry we misunderstood. The user needs to pass in a TransformStream as the decrypt argument. What we have here is still the same DoS vector. |
And if possible, please add tests and make sure decryption occurs after inflation. |
0ad1d88
to
2a2f471
Compare