Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update test dependencies #585

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: update test dependencies #585

wants to merge 1 commit into from
+3 −3

Conversation

Phillip9587
Copy link
Contributor

Updated mocha, nyc, and supertest to their latest versions.

@socket-security Socket Security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] 🔁 npm/[email protected] Transitive: shell +87 8.44 MB joshuakgoldberg, uzlopak, voxpelli
npm/[email protected] 🔁 npm/[email protected] Transitive: eval, shell +139 15 MB bcoe
npm/[email protected] 🔁 npm/[email protected] Transitive: environment, filesystem +18 1.23 MB titanism

View full report↗︎

@jonchurch
Copy link
Member

jonchurch commented Feb 19, 2025 •
edited
Loading

Mocha went to 18.18.0 https://github.com/mochajs/mocha/pull/5216/files?diff=unified#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R43 whereas we support 18.0.0, which is annoying for us if we want to test on 18.0.0 specifically, but otherwise Im in favor.

Edit: Confirmed that we can still run mocha even on 18.0.0

@bjohansebas
Copy link
Member

We should update our CI to verify that it continues to work on both 18.0.0 and 20.0.0, as well as the latest releases of those versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleytodd wesleytodd wesleytodd approved these changes

@jonchurch jonchurch jonchurch approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Phillip9587 @jonchurch @bjohansebas @wesleytodd