-
Notifications
You must be signed in to change notification settings - Fork 152
E2512: Reimplement Responses_Controller #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MGuron
wants to merge
67
commits into
expertiza:main
Choose a base branch
from
ellie-not-found:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Email logic & Parameter assignment to helpers/services
Revert "Email logic & Parameter assignment to helpers/services"
Moved sorting logic to model
Refactor qbrm method
…tion-back-end into Set-Content
Set content & assign action params
Added method for new and related helpers. Slight updates to existing …
Implement new create
Added index+show
Finished new and create tests
Copied Eleanor's code and fixed test with current setup
new_feedback reimplementation
Implemented save function
fixed tests in controller and helper
# Conflicts: # app/controllers/api/v1/responses_controller.rb # app/helpers/responses_helper.rb
Toggle permission
added action allowed and tests
This reverts commit a67212a.
finished tests
move redirect method and created routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E2512 Project