Flexible SQL instance names #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed syntax bug bumped version bumped version 2 updated version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Goodrum,
In this pull request I would like to propose we make the default SQL instance name flexible trough an attribute and change the default to "VeeamSQL2016". Currently the cookbook uses the instance name "VeeamSQL2012" for all installations. However according to the Veeam documentation "VeeamSQL2012" is only used for operating systems prior to Server 2008 R2 and Windows 7. Everything beyond that should use "VeeamSQL2016" which is the majority of users.
Source: https://helpcenter.veeam.com/docs/backup/hyperv/install_vbr_sql.html?ver=100
Note: It seems what is stated in the documentation is true for manual installations. When performing an unattended installation however the default seems to fall back on "VeeamSQL2012" despite the OS. This is a bug in the Veeam installer. The proposed adjustments compensate for this bug.