Hotfix PR229 #230
Merged
Hotfix PR229 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.2 → v0.6.3](astral-sh/ruff-pre-commit@v0.6.2...v0.6.3) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…xoplanet-dev#208) Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.3 → v0.6.4](astral-sh/ruff-pre-commit@v0.6.3...v0.6.4) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* ipython version backend update * add .vscode to gitignore file * align occultation plot
* feat: add a multi-precision module for testing * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: linter errors * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: a closed form multi-precision A2 (way faster than inverting A2_inv) * fix: mp diff * feat: caching big matrices * fix: avoid adding zero elements * test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: top-level imports error * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: cached matrices as kwarg * feat: add gmpy2 for faster multi-precision arithmetic * fix: slightly change the caching per module * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: cache added for R * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: caching or R * fix: remove precision plots from tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ev#216) * feat: add a multi-precision module for testing * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: linter errors * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: a closed form multi-precision A2 (way faster than inverting A2_inv) * fix: mp diff * feat: caching big matrices * fix: avoid adding zero elements * test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: top-level imports error * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: cached matrices as kwarg * feat: add gmpy2 for faster multi-precision arithmetic * fix: slightly change the caching per module * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: cache added for R * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: caching or R * fix: remove precision plots from tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: properly cache sT * fix: index as static method * fix: remove unused variable * fix: redo last theta_z rotation --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
exoplanet-dev#218) * test: move multi-precision to general tests + supersede sympy symbolic * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: move import in multiprecision tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * test: add test R multi-precision * fix: move mpmath import to skipped test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: missing import * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: move import within skipped function --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.4 → v0.6.5](astral-sh/ruff-pre-commit@v0.6.4...v0.6.5) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.5 → v0.6.7](astral-sh/ruff-pre-commit@v0.6.5...v0.6.7) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…anet-dev#223) * feat: secondary/emission light curve of (limb-darkened) bodies * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: pin jax version --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…xoplanet-dev#222) Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.10.0 to 1.10.2. - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.10.0...v1.10.2) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add a multi-precision module for testing * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: linter errors * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: a closed form multi-precision A2 (way faster than inverting A2_inv) * fix: mp diff * feat: caching big matrices * fix: avoid adding zero elements * test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: top-level imports error * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: cached matrices as kwarg * feat: add gmpy2 for faster multi-precision arithmetic * feat: s2fft rotation matrices * fix: slightly change the caching per module * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: cache added for R * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: add s2fft dep * fix: skip long comparison to R symbolic (starry comparison is enough) * fix: avoid nans and nan grads * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: caching or R * fix: solution cache * fix: using single Ylm (ones) to test and plot precision * fix: index as static method * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: remove precision plots from tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: properly cache sT * fix: index as static method * fix: remove unused variable * fix: redo last theta_z rotation * fix: import issue coming from s2fft by using numpy<2.0 * feat: improved p integrals using symmetry and small order elements * fix: sT key error in cached matrices * fix: module level import * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: apply symmetry to limb-dark P integral * feat: pytest verbose flag * test: check if test_compare_y_from_u is problematic * test: test failure of other test on macos * Don't run tests in parallel? * feat: secondary/emission light curve of (limb-darkened) bodies * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: pin jax version * fix: jax<=0.4.31 * fix: trying to fix macos-latest tests * fix: trying to fix macos-latest tests * fix: copying s2fft functions to avoid macos tests freezing. Remove s2fft dep * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: line too long and None cond (linter) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: no test skipped now that macos test bug solved * fix: bad indent in docs * fix: bad indent in docs * fix: remove docstring from s2fft copied functions and turn to private * feat: allow None values for angles related to rotations + fix phase of surface * fix: conversion to starry test + docstrings * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: angles property for Surface --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dan Foreman-Mackey <[email protected]>
* feat: add a multi-precision module for testing * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: linter errors * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: a closed form multi-precision A2 (way faster than inverting A2_inv) * fix: mp diff * feat: caching big matrices * fix: avoid adding zero elements * test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: top-level imports error * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: cached matrices as kwarg * feat: add gmpy2 for faster multi-precision arithmetic * feat: s2fft rotation matrices * fix: slightly change the caching per module * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: cache added for R * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: add s2fft dep * fix: skip long comparison to R symbolic (starry comparison is enough) * fix: avoid nans and nan grads * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: caching or R * fix: solution cache * fix: using single Ylm (ones) to test and plot precision * fix: index as static method * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: remove precision plots from tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: properly cache sT * fix: index as static method * fix: remove unused variable * fix: redo last theta_z rotation * fix: import issue coming from s2fft by using numpy<2.0 * fix: sT key error in cached matrices * fix: module level import * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: pytest verbose flag * test: check if test_compare_y_from_u is problematic * test: test failure of other test on macos * Don't run tests in parallel? * feat: secondary/emission light curve of (limb-darkened) bodies * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: pin jax version * fix: jax<=0.4.31 * fix: copying s2fft functions to avoid macos tests freezing. Remove s2fft dep * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: line too long and None cond (linter) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: no test skipped now that macos test bug solved * fix: bad indent in docs * fix: remove docstring from s2fft copied functions and turn to private * fix: add note and license + jp.stack instead of loop * fix: revert changes for testing * fix: revert _generate_rotate_dls jnp.stack change * feat: allow higher precision design matrices (for test only) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: optional mpmath import * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: optional mpmath import * fix: mpmath matrices caching for flux * feat: improve _generate_rotate_dls * test(fix): revert parallel tests --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dan Foreman-Mackey <[email protected]>
* feat: add a multi-precision module for testing * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: linter errors * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: a closed form multi-precision A2 (way faster than inverting A2_inv) * fix: mp diff * feat: caching big matrices * fix: avoid adding zero elements * test: multi-precision rotation matrices, basis,solution and flux. At low lmax for now * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: top-level imports error * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: cached matrices as kwarg * feat: add gmpy2 for faster multi-precision arithmetic * feat: s2fft rotation matrices * fix: slightly change the caching per module * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: cache added for R * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: add s2fft dep * fix: skip long comparison to R symbolic (starry comparison is enough) * fix: avoid nans and nan grads * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: caching or R * fix: solution cache * fix: using single Ylm (ones) to test and plot precision * fix: index as static method * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: remove precision plots from tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: properly cache sT * fix: index as static method * fix: remove unused variable * fix: redo last theta_z rotation * fix: import issue coming from s2fft by using numpy<2.0 * feat: improved p integrals using symmetry and small order elements * fix: sT key error in cached matrices * fix: module level import * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat: apply symmetry to limb-dark P integral * feat: pytest verbose flag * test: check if test_compare_y_from_u is problematic * test: test failure of other test on macos * Don't run tests in parallel? * feat: secondary/emission light curve of (limb-darkened) bodies * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: pin jax version * fix: jax<=0.4.31 * fix: trying to fix macos-latest tests * fix: trying to fix macos-latest tests * fix: copying s2fft functions to avoid macos tests freezing. Remove s2fft dep * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: line too long and None cond (linter) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: no test skipped now that macos test bug solved * fix: bad indent in docs * fix: bad indent in docs * fix: remove docstring from s2fft copied functions and turn to private * fix: add note and license + jp.stack instead of loop * fix: revert changes for testing * fix: revert _generate_rotate_dls jnp.stack change * feat: allow higher precision design matrices (for test only) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: optional mpmath import * fix: optional mpmath import * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: optional mpmath import * fix: mpmath matrices caching for flux * fix: min low_order * feat: a function to estimate the precision of different light curves, including limb darkened one * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: typo * feat: improve _generate_rotate_dls * fix: minimum low order * fix: move mpmath import in test function * fix: remove duplicate CACHED_MATRICES --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dan Foreman-Mackey <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve the bug that's mentioned in #229.
The fix is to just create an
if elsebranch in theconverter(value)function to returnNoneifvalue=Noneand otherwise to use thetree.mapfunctionality to apply units.@dfm: Could you let me know if these changes are the right way to handle this bug?