Runner error handling#2093
Open
AndreiCravtov wants to merge 38 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runner error handling
Motivation
Runner failures were mostly surfaced as plain shutdown messages, which made root cause hard to spot from API errors or runner status.
This adds a MVP path for preserving runner crash context and attaching known stderr diagnostics to failure reports.
Changes
RunnerTerminationErrorfor Python exceptions raised inside runner bootstrapEvent | RunnerTerminationErrorover the private runner channelRunnerFailedemission back into supervisorRunnerDiagnosticCollectorRunnerFailedandErrorChunkWhy It Works
Runner child now reports raw-ish failure context to supervisor instead of publishing failed status directly.
Supervisor still owns process lifecycle, exit code/signal handling, in-flight task error chunks, and final runner status. Stderr diagnostics stay best effort and only known root-cause variants are surfaced.
Test Plan
Manual Testing
Hardware: remote runner logs from e16/e11/e4/e2
What you did:
Automated Testing
nix flake check