feat: initial image generation support #1095
Conversation
ciaranbor
force-pushed
the
ciaran/image-generation
branch
12 times, most recently
from
02bfd7b to
0783aaf
Compare
| model_card = MODEL_CARDS[model_id] | ||
| return model_card | ||
|
|
||
| for _, model_card in MODEL_CARDS.items(): |
There was a problem hiding this comment.
opinion, not functionality - we should change the MODEL_CARDS to be keyed by model_id and drop the model_id field from them. the short ids are confusing.
| user: str | None = None | ||
|
|
||
|
|
||
| class ImageEditsTaskParams(BaseModel): |
There was a problem hiding this comment.
Potential / TODO / your discretion: OpenAI API compat here.
| ) | ||
|
|
||
| self.command_task_mapping[command.command_id] = task_id | ||
| case ImageGeneration(): |
There was a problem hiding this comment.
As you mentioned, seems the most generic code - ideally we'd delegate to a load balancer here I suppose.
| n: int | None = 1 | ||
| quality: Literal["high", "medium", "low"] | None = "medium" | ||
| output_format: Literal["png", "jpeg", "webp"] = "png" | ||
| response_format: Literal["url", "b64_json"] | None = "b64_json" |
| from pathlib import Path | ||
| from typing import Callable, Literal | ||
| from urllib.parse import urljoin | ||
| from huggingface_hub._snapshot_download import snapshot_download |
There was a problem hiding this comment.
Can't say I'm a huge fan, but that's all of download_utils.
| from exo.worker.runner.bootstrap import logger | ||
|
|
||
|
|
||
| class DistributedImageModel: |
There was a problem hiding this comment.
ok surely this should actually be a dataclass
src/exo/worker/plan.py
Outdated
| if ( | ||
| not isinstance(task, ChatCompletion) | ||
| and not isinstance(task, ImageGeneration) | ||
| and not isinstance(task, ImageEdits) |
There was a problem hiding this comment.
not isinstance(task, (ChatCompletion, ImageGeneration, ImageEdits)) works
|
We've discussed plenty, my review is mostly to submit comments that are mainly stylistic. My main aims are to standardise what data we use to shard and parallelise and evaluate model scheduling and placement. |
ciaranbor
force-pushed
the
ciaran/image-generation
branch
16 times, most recently
from
791bbb1 to
3a579cc
Compare
ciaranbor
force-pushed
the
ciaran/image-generation
branch
from
ad5703f to
b644490
Compare
ciaranbor
force-pushed
the
ciaran/image-generation
branch
from
b644490 to
29191b0
Compare
ciaranbor
force-pushed
the
ciaran/image-generation
branch
from
d3c1e6a to
01148d5
Compare
ciaranbor
force-pushed
the
ciaran/image-generation
branch
from
0fa5f0f to
5ac44a0
Compare
ciaranbor
force-pushed
the
ciaran/image-generation
branch
from
2668c6c to
a315e68
Compare
ciaranbor
force-pushed
the
ciaran/image-generation
branch
from
cad4502 to
4519548
Compare
ciaranbor
force-pushed
the
ciaran/image-generation
branch
from
c1fb4a5 to
04cd02b
Compare
Motivation
Changes
Why It Works
Test Plan
Manual Testing
Automated Testing