Updating tests for armstrong-numbers #2577
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
@Cool-Katt, the last two tests are not consistent yet, as they're currently taking different approaches. Let me know which approach you'd prefer me to implement for both. |
|
I'm thinking that the one that explicitly passes a |
|
Sure @Cool-Katt, I'll make the changes ASAP! |
| description = "Single-digit numbers are Armstrong numbers" | ||
|
|
||
| [2d6db9dc-5bf8-4976-a90b-b2c2b9feba60] | ||
| description = "There are no 2 digit Armstrong numbers" | ||
| description = "There are no two-digit Armstrong numbers" | ||
|
|
||
| [509c087f-e327-4113-a7d2-26a4e9d18283] | ||
| description = "Three digit number that is an Armstrong number" | ||
| description = "Three-digit number that is an Armstrong number" | ||
|
|
||
| [7154547d-c2ce-468d-b214-4cb953b870cf] | ||
| description = "Three digit number that is not an Armstrong number" | ||
| description = "Three-digit number that is not an Armstrong number" | ||
|
|
||
| [6bac5b7b-42e9-4ecb-a8b0-4832229aa103] | ||
| description = "Four digit number that is an Armstrong number" | ||
| description = "Four-digit number that is an Armstrong number" | ||
|
|
||
| [eed4b331-af80-45b5-a80b-19c9ea444b2e] | ||
| description = "Four digit number that is not an Armstrong number" | ||
| description = "Four-digit number that is not an Armstrong number" | ||
|
|
||
| [f971ced7-8d68-4758-aea1-d4194900b864] | ||
| description = "Seven digit number that is an Armstrong number" | ||
| description = "Seven-digit number that is an Armstrong number" | ||
|
|
||
| [7ee45d52-5d35-4fbd-b6f1-5c8cd8a67f18] | ||
| description = "Seven digit number that is not an Armstrong number" | ||
| description = "Seven-digit number that is not an Armstrong number" |
There was a problem hiding this comment.
Other test descriptions needs to be updated to match this.
|
|
||
| xtest('The largest and last Armstrong number', () => { | ||
| expect( | ||
| isArmstrongNumber(`115132219018763992565095597973971522401`), |
There was a problem hiding this comment.
| isArmstrongNumber(`115132219018763992565095597973971522401`), | |
| isArmstrongNumber(115132219018763992565095597973971522401n), |
|
@SleeplessByte, I've made all the changes you requested. However, could you please clarify what you meant by adding an |
|
Certainly This exercise is synced with the problem-specifications, so when a change is introduced there, we receive it via pull request. This will replace the We now want to add a note to that file that the solution needs to be able to handle However:
Edit or create this file for this exercise and it will remain in place when the main instructions are updated. |
|
Sure, I'll make the changes as soon as possible! Additionally, I had a question unrelated to the PR, so I’ve sent an email to the address listed on your GitHub profile since GitHub doesn’t support direct messaging. I’d really appreciate it if you could take a look. Thank you! |
I found it! |
exercises/practice/armstrong-numbers/.docs/instructions.append.md
Outdated
Show resolved
Hide resolved
|
Hi @SleeplessByte and @Cool-Katt, Please let me know if there's anything else you'd like me to address or adjust in this PR. I'm happy to make any necessary updates! |
Pull Request
This PR adds two new test cases to the Armstrong-Numbers exercise to align it with the
problem-specificationsrepository. However, both numbers in these new tests are extremely large and will cause thetest-runnerto fail. Please let me know how you'd like me to proceed with this!