-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement JS-esque StateBase.srcCharCodeAt
#190
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
- Coverage 96.17% 96.11% -0.07%
==========================================
Files 61 61
Lines 3267 3267
==========================================
- Hits 3142 3140 -2
- Misses 125 127 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Seeing that this PR only removes 4 instances of The downsides for rejecting are diverging slightly from upstream logic, and the chance that there's still some place in the code where |
Replaces use of
StateBase.srcCharCode
with the more JS-esqueStateBase.srcCharCodeAt
that can returnNone
.I didn't remove
StateBase.srcCharCode
for ease of migration because mdit-py-plugins use it. But did deprecate it.Happy to hear what you think @chrisjsewell . Not sure if this is the solution or migration strategy you want, but it's something 😄
I haven't measured performance yet. We may want to do that if this is something we want to proceed with otherwise
EDIT: This PR is in response to discussion in #186