Rename commit -> cache
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename user-facing `PK` -> `ID`
Closed
|
Nice - I think it's a more intuitive word for folks, and helps avoid confusion that this behaves exactly like git. One thought I had: One thing that might cause confusion is the difference between the verb "to cache" and the noun "the cache". Are there instances where this could be ambiguous? |
Well I can't think of any off hand, but its certainly something to bear in mind when writing the documentation and CLI docstrings. I'll merge this now, so we can move on to #18 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed everywhere in package.
Also renamed user-facing
PK->ID.Addresses part of #16 feedback