Skip to content

Add rate limiting support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add rate limiting support #2

wants to merge 3 commits into from

Conversation

ejsmith
Copy link
Member

@ejsmith ejsmith commented Jul 14, 2025

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@niemyjski niemyjski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I'm wondering how I would use a middleware to update existing rate limit config based on header values for both rate limit remaining and reate limit reset time

@ejsmith
Copy link
Member Author

ejsmith commented Jul 14, 2025

Overall looks good. I'm wondering how I would use a middleware to update existing rate limit config based on header values for both rate limit remaining and reate limit reset time

I don't really see it as something we should be updating dynamically. You can do that by just going to the provider.rateLimiter.config but this is just really meant more to keep us from DoS ourselves due to bad reactive code.

@niemyjski
Copy link
Member

Our api returns the rare limit in real time, would be nice to use that. Also some routes are not rate limited.

@ejsmith
Copy link
Member Author

ejsmith commented Jul 14, 2025

Yeah, that would be kind of nice to respond to that. Although, wasn't it just for posting events?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants